2019-05-15 11:54:56

by Zenghui Yu

Subject: [PATCH] perf jevents: Remove unused variables

Fix gcc warning:

pmu-events/jevents.c: In function ‘save_arch_std_events’:
pmu-events/jevents.c:417:15: warning: unused variable ‘sb’ [-Wunused-variable]
struct stat *sb = data;
^~

Signed-off-by: Zenghui Yu <[email protected]>
---
tools/perf/pmu-events/jevents.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
index 68c92bb..92e60fd 100644
--- a/tools/perf/pmu-events/jevents.c
+++ b/tools/perf/pmu-events/jevents.c
@@ -414,7 +414,6 @@ static int save_arch_std_events(void *data, char *name, char *event,
char *metric_name, char *metric_group)
{
struct event_struct *es;
- struct stat *sb = data;

es = malloc(sizeof(*es));
if (!es)
--
1.8.3.1

2019-05-15 19:13:41

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf jevents: Remove unused variables

Em Wed, May 15, 2019 at 11:19:29AM +0000, Zenghui Yu escreveu:
> Fix gcc warning:

s/Fix/Address/g

Thanks, applied.

- Arnaldo

> pmu-events/jevents.c: In function ‘save_arch_std_events’:
> pmu-events/jevents.c:417:15: warning: unused variable ‘sb’ [-Wunused-variable]
> struct stat *sb = data;
> ^~
>
> Signed-off-by: Zenghui Yu <[email protected]>
> ---
> tools/perf/pmu-events/jevents.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 68c92bb..92e60fd 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -414,7 +414,6 @@ static int save_arch_std_events(void *data, char *name, char *event,
> char *metric_name, char *metric_group)
> {
> struct event_struct *es;
> - struct stat *sb = data;
>
> es = malloc(sizeof(*es));
> if (!es)
> --
> 1.8.3.1
>

--

- Arnaldo

2019-05-18 09:51:43

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/core] perf jevents: Remove unused variable

Commit-ID: 8e8f515d567f9ec1d960e9fdb117d39753b7504d
Gitweb: https://git.kernel.org/tip/8e8f515d567f9ec1d960e9fdb117d39753b7504d
Author: Zenghui Yu <[email protected]>
AuthorDate: Wed, 15 May 2019 11:19:29 +0000
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 15 May 2019 16:36:49 -0300

perf jevents: Remove unused variable

Address gcc warning:

pmu-events/jevents.c: In function ‘save_arch_std_events’:
pmu-events/jevents.c:417:15: warning: unused variable ‘sb’ [-Wunused-variable]
struct stat *sb = data;
^~

Signed-off-by: Zenghui Yu <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: John Garry <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/pmu-events/jevents.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
index daaea5003d4a..58f77fd0f59f 100644
--- a/tools/perf/pmu-events/jevents.c
+++ b/tools/perf/pmu-events/jevents.c
@@ -415,7 +415,6 @@ static int save_arch_std_events(void *data, char *name, char *event,
char *metric_name, char *metric_group)
{
struct event_struct *es;
- struct stat *sb = data;

es = malloc(sizeof(*es));
if (!es)