2019-05-20 06:02:26

by Yi Wang

Subject: [PATCH] kvm: vmx: Fix -Wmissing-prototypes warnings

We get a warning when build kernel W=1:
arch/x86/kvm/vmx/vmx.c:6365:6: warning: no previous prototype for ‘vmx_update_host_rsp’ [-Wmissing-prototypes]
void vmx_update_host_rsp(struct vcpu_vmx *vmx, unsigned long host_rsp)

Add the missing declaration to fix this.

Signed-off-by: Yi Wang <[email protected]>
---
arch/x86/kvm/vmx/vmx.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
index f879529..9cd72de 100644
--- a/arch/x86/kvm/vmx/vmx.h
+++ b/arch/x86/kvm/vmx/vmx.h
@@ -314,6 +314,7 @@ struct kvm_vmx {
void vmx_set_virtual_apic_mode(struct kvm_vcpu *vcpu);
struct shared_msr_entry *find_msr_entry(struct vcpu_vmx *vmx, u32 msr);
void pt_update_intercept_for_msr(struct vcpu_vmx *vmx);
+void vmx_update_host_rsp(struct vcpu_vmx *vmx, unsigned long host_rsp);

#define POSTED_INTR_ON 0
#define POSTED_INTR_SN 1
--
1.8.3.1

2019-05-20 14:23:01

by Paolo Bonzini

Subject: Re: [PATCH] kvm: vmx: Fix -Wmissing-prototypes warnings

On 20/05/19 06:27, Yi Wang wrote:
> We get a warning when build kernel W=1:
> arch/x86/kvm/vmx/vmx.c:6365:6: warning: no previous prototype for ‘vmx_update_host_rsp’ [-Wmissing-prototypes]
> void vmx_update_host_rsp(struct vcpu_vmx *vmx, unsigned long host_rsp)
>
> Add the missing declaration to fix this.
>
> Signed-off-by: Yi Wang <[email protected]>
> ---
> arch/x86/kvm/vmx/vmx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
> index f879529..9cd72de 100644
> --- a/arch/x86/kvm/vmx/vmx.h
> +++ b/arch/x86/kvm/vmx/vmx.h
> @@ -314,6 +314,7 @@ struct kvm_vmx {
> void vmx_set_virtual_apic_mode(struct kvm_vcpu *vcpu);
> struct shared_msr_entry *find_msr_entry(struct vcpu_vmx *vmx, u32 msr);
> void pt_update_intercept_for_msr(struct vcpu_vmx *vmx);
> +void vmx_update_host_rsp(struct vcpu_vmx *vmx, unsigned long host_rsp);
>
> #define POSTED_INTR_ON 0
> #define POSTED_INTR_SN 1
>

Queued, thanks.

Paolo