Hi all,
In commit
0d90ccb70211 ("drm/i915: Delay semaphore submission until the start of the signaler")
Fixes tag
Fixes: e88619646971 ("drm/i915: Use HW semaphores for inter-engine synchroni
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please don't split Fixes tags across more than one line.
--
Cheers,
Stephen Rothwell
Quoting Stephen Rothwell (2019-05-20 15:15:38)
> Hi all,
>
> In commit
>
> 0d90ccb70211 ("drm/i915: Delay semaphore submission until the start of the signaler")
>
> Fixes tag
>
> Fixes: e88619646971 ("drm/i915: Use HW semaphores for inter-engine synchroni
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please don't split Fixes tags across more than one line.
Thanks for the report.
This was a copy'n paste mishap, detected by our tooling (and fixed by
me) at the time of creating a PR. Unfortunately the check was not being
enforced by tooling at commit time. We'll fix that.
Regards, Joonas
We also have an incoming patch where the Fixes: line has a comment in
it. Does your tooling account for this when checking the Fixes: line?
Regards, Joonas
Hi Joonas,
On Tue, 21 May 2019 16:04:16 +0300 Joonas Lahtinen <[email protected]> wrote:
>
> We also have an incoming patch where the Fixes: line has a comment in
> it. Does your tooling account for this when checking the Fixes: line?
I will make sure mine does.
--
Cheers,
Stephen Rothwell