2019-05-22 10:48:39

by Puneet Saxena

Subject: [PATCH] ignore disabled memory-region nodes

While parsing "memory-region" node lists if a node is
"disabled", parsing halts. Therefore the nodes whose
"status" is "okay" or "ok" are not parsed.

The change ignores disabled nodes in the memory-region
nodes list and returns 0 to continue parsing next nodes.

---
v2:
* Fixed typo in commit message.
* Used of_device_is_available to check device is disabled/enabled.

Krishna Reddy (1):
of: reserved-memory: ignore disabled memory-region nodes

drivers/of/of_reserved_mem.c | 3 +++
1 file changed, 3 insertions(+)

--
2.7.4

2019-05-22 10:49:19

by Puneet Saxena

Subject: [PATCH V2] of: reserved-memory: ignore disabled memory-region nodes

From: Krishna Reddy <[email protected]>

Ignore disabled nodes in the memory-region
nodes list and continue to initialize the rest
of enabled nodes.

Check if the "reserved-memory" node is available
and if it's not available, return 0 to ignore the
"reserved-memory" node and continue parsing with
next node in memory-region nodes list.

Signed-off-by: Krishna Reddy <[email protected]>
Signed-off-by: Puneet Saxena <[email protected]>
---
v2:
* Fixed typo in commit message.
* Used "of_device_is_available" to check "reserved-memory"
nodes are disabled/enabled.

drivers/of/of_reserved_mem.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
index 1977ee0adcb1..b0b7a0c4431d 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -322,6 +322,9 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
if (!target)
return -ENODEV;

+ if (!of_device_is_available(target))
+ return 0;
+
rmem = __find_rmem(target);
of_node_put(target);

--
2.7.4

2019-05-24 20:54:55

by Rob Herring (Arm)

Subject: Re: [PATCH V2] of: reserved-memory: ignore disabled memory-region nodes

On Wed, 22 May 2019 16:17:11 +0530, Puneet Saxena wrote:
> From: Krishna Reddy <[email protected]>
>
> Ignore disabled nodes in the memory-region
> nodes list and continue to initialize the rest
> of enabled nodes.
>
> Check if the "reserved-memory" node is available
> and if it's not available, return 0 to ignore the
> "reserved-memory" node and continue parsing with
> next node in memory-region nodes list.
>
> Signed-off-by: Krishna Reddy <[email protected]>
> Signed-off-by: Puneet Saxena <[email protected]>
> ---
> v2:
> * Fixed typo in commit message.
> * Used "of_device_is_available" to check "reserved-memory"
> nodes are disabled/enabled.
>
> drivers/of/of_reserved_mem.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Applied, thanks.

Rob