2019-05-31 09:07:00

by Yonglong Liu

Subject: [PATCH net] net: hns: Fix loopback test failed at copper ports

When doing a loopback test at copper ports, the serdes loopback
and the phy loopback will fail, because of the adjust link had
not finished, and phy not ready.

Adds sleep between adjust link and test process to fix it.

Signed-off-by: Yonglong Liu <[email protected]>
---
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
index ce15d23..188c3f6 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
@@ -339,6 +339,7 @@ static int __lb_setup(struct net_device *ndev,
static int __lb_up(struct net_device *ndev,
enum hnae_loop loop_mode)
{
+#define NIC_LB_TEST_WAIT_PHY_LINK_TIME 300
struct hns_nic_priv *priv = netdev_priv(ndev);
struct hnae_handle *h = priv->ae_handle;
int speed, duplex;
@@ -365,6 +366,9 @@ static int __lb_up(struct net_device *ndev,

h->dev->ops->adjust_link(h, speed, duplex);

+ /* wait adjust link done and phy ready */
+ msleep(NIC_LB_TEST_WAIT_PHY_LINK_TIME);
+
return 0;
}

--
2.8.1

2019-06-02 21:13:51

by David Miller

Subject: Re: [PATCH net] net: hns: Fix loopback test failed at copper ports

From: Yonglong Liu <[email protected]>
Date: Fri, 31 May 2019 16:59:50 +0800

> When doing a loopback test at copper ports, the serdes loopback
> and the phy loopback will fail, because of the adjust link had
> not finished, and phy not ready.
>
> Adds sleep between adjust link and test process to fix it.
>
> Signed-off-by: Yonglong Liu <[email protected]>

Applied.