2019-06-20 15:53:58

by Sameer Pujar

[permalink] [raw]

Subject: [PATCH] bus: tegra-aconnect: remove PM_CLK dependency

---

aconnect bus driver does not use pm-clk interface now and hence the
dependency is removed from Kconfig.

Signed-off-by: Sameer Pujar <[email protected]>
---
drivers/bus/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 1851112..4587ef2 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -128,7 +128,6 @@ config TEGRA_ACONNECT
tristate "Tegra ACONNECT Bus Driver"
depends on ARCH_TEGRA_210_SOC
depends on OF && PM
- select PM_CLK
help
Driver for the Tegra ACONNECT bus which is used to interface with
the devices inside the Audio Processing Engine (APE) for Tegra210.
--
2.7.4

2019-06-20 16:04:14

by Jon Hunter

[permalink] [raw]

Subject: Re: [PATCH] bus: tegra-aconnect: remove PM_CLK dependency

---

On 20/06/2019 16:51, Sameer Pujar wrote:
> aconnect bus driver does not use pm-clk interface now and hence the
> dependency is removed from Kconfig.
>
> Signed-off-by: Sameer Pujar <[email protected]>
> ---
> drivers/bus/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 1851112..4587ef2 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -128,7 +128,6 @@ config TEGRA_ACONNECT
> tristate "Tegra ACONNECT Bus Driver"
> depends on ARCH_TEGRA_210_SOC
> depends on OF && PM
> - select PM_CLK
> help
> Driver for the Tegra ACONNECT bus which is used to interface with
> the devices inside the Audio Processing Engine (APE) for Tegra210.

Thanks. We should probably populate the 'Fixes:' tag for this to show
which commit this fixes. Otherwise ...

Acked-by: Jon Hunter <[email protected]>

Cheers
Jon

--
nvpublic

2020-01-10 11:34:13

by Thierry Reding

[permalink] [raw]

Subject: Re: [PATCH] bus: tegra-aconnect: remove PM_CLK dependency

---

On Thu, Jun 20, 2019 at 05:02:27PM +0100, Jon Hunter wrote:
>
> On 20/06/2019 16:51, Sameer Pujar wrote:
> > aconnect bus driver does not use pm-clk interface now and hence the
> > dependency is removed from Kconfig.
> >
> > Signed-off-by: Sameer Pujar <[email protected]>
> > ---
> > drivers/bus/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> > index 1851112..4587ef2 100644
> > --- a/drivers/bus/Kconfig
> > +++ b/drivers/bus/Kconfig
> > @@ -128,7 +128,6 @@ config TEGRA_ACONNECT
> > tristate "Tegra ACONNECT Bus Driver"
> > depends on ARCH_TEGRA_210_SOC
> > depends on OF && PM
> > - select PM_CLK
> > help
> > Driver for the Tegra ACONNECT bus which is used to interface with
> > the devices inside the Audio Processing Engine (APE) for Tegra210.
>
> Thanks. We should probably populate the 'Fixes:' tag for this to show
> which commit this fixes. Otherwise ...
>
> Acked-by: Jon Hunter <[email protected]>

Looks like this was never applied. I don't recollect that there was a
specific reason why we shouldn't, so I went ahead and applied this after
adding:

Fixes: 0d7dab926130 ("bus: tegra-aconnect: use devm_clk_*() helpers")

Thanks,
Thierry

---

Attachments:

(No filename) (1.25 kB)
signature.asc (849.00 B)
Download all attachments