2019-07-11 09:32:44

by Paolo Pisati

[permalink] [raw]
Subject: [PATCH 1/2] bpf: bpf_csum_diff: fold the checksum before returning the value

From: Paolo Pisati <[email protected]>

With this change, bpf_csum_diff behave homogeneously among different
checksum calculation code / csum_partial() (tested on x86-64, arm64 and
arm).

Signed-off-by: Paolo Pisati <[email protected]>
---
net/core/filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/filter.c b/net/core/filter.c
index f615e42cf4ef..8db7f58f1ea1 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -1990,7 +1990,7 @@ BPF_CALL_5(bpf_csum_diff, __be32 *, from, u32, from_size,
for (i = 0; i < to_size / sizeof(__be32); i++, j++)
sp->diff[j] = to[i];

- return csum_partial(sp->diff, diff_size, seed);
+ return csum_fold(csum_partial(sp->diff, diff_size, seed));
}

static const struct bpf_func_proto bpf_csum_diff_proto = {
--
2.17.1