2019-07-15 04:38:35

by Yi Wang

Subject: [PATCH] kvm: vmx: fix coccinelle warnings

This fixes the following coccinelle warning:

WARNING: return of 0/1 in function 'vmx_need_emulation_on_page_fault'
with return type bool

Return false instead of 0.

Signed-off-by: Yi Wang <[email protected]>
---
arch/x86/kvm/vmx/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index d98eac3..8b5f352 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -7418,7 +7418,7 @@ static int enable_smi_window(struct kvm_vcpu *vcpu)

static bool vmx_need_emulation_on_page_fault(struct kvm_vcpu *vcpu)
{
- return 0;
+ return false;
}

static __init int hardware_setup(void)
--
1.8.3.1

2019-07-15 11:56:59

by Paolo Bonzini

Subject: Re: [PATCH] kvm: vmx: fix coccinelle warnings

On 15/07/19 06:35, Yi Wang wrote:
> This fixes the following coccinelle warning:
>
> WARNING: return of 0/1 in function 'vmx_need_emulation_on_page_fault'
> with return type bool
>
> Return false instead of 0.
>
> Signed-off-by: Yi Wang <[email protected]>
> ---
> arch/x86/kvm/vmx/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index d98eac3..8b5f352 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7418,7 +7418,7 @@ static int enable_smi_window(struct kvm_vcpu *vcpu)
>
> static bool vmx_need_emulation_on_page_fault(struct kvm_vcpu *vcpu)
> {
> - return 0;
> + return false;
> }
>
> static __init int hardware_setup(void)
>

Queued, thanks.

Paolo