Subject: [PATCH 3/6] leds: apu: drop iosize field from priv data

From: Enrico Weigelt <[email protected]>

As this driver now only supports the APU1 boards, we don't need
to handle different io sizes anymore.

Signed-off-by: Enrico Weigelt <[email protected]>
---
drivers/leds/leds-apu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/leds/leds-apu.c b/drivers/leds/leds-apu.c
index 37b054f..f79146c 100644
--- a/drivers/leds/leds-apu.c
+++ b/drivers/leds/leds-apu.c
@@ -71,7 +71,6 @@ struct apu_led_pdata {
struct apu_led_priv *pled;
const struct apu_led_profile *profile;
int num_led_instances;
- int iosize; /* for devm_ioremap() */
spinlock_t lock;
};

@@ -127,7 +126,7 @@ static int apu_led_config(struct device *dev, struct apu_led_pdata *apuld)
led_cdev->brightness_set = apu1_led_brightness_set;

pled->param.addr = devm_ioremap(dev,
- apu_led->profile[i].offset, apu_led->iosize);
+ apu_led->profile[i].offset, APU1_IOSIZE);
if (!pled->param.addr) {
err = -ENOMEM;
goto error;
@@ -160,7 +159,6 @@ static int __init apu_led_probe(struct platform_device *pdev)

apu_led->profile = apu1_led_profile;
apu_led->num_led_instances = ARRAY_SIZE(apu1_led_profile);
- apu_led->iosize = APU1_IOSIZE;

spin_lock_init(&apu_led->lock);
return apu_led_config(&pdev->dev, apu_led);
--
1.9.1


2019-07-16 19:28:04

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 3/6] leds: apu: drop iosize field from priv data

On Mon 2019-07-15 16:57:30, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <[email protected]>
>
> As this driver now only supports the APU1 boards, we don't need
> to handle different io sizes anymore.
>
> Signed-off-by: Enrico Weigelt <[email protected]>

Acked-by: Pavel Machek <[email protected]>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments:
(No filename) (458.00 B)
 signature.asc (188.00 B)
Digital signature Download all attachments