2002-06-20 02:19:03

by Stephen Rothwell

Subject: [PATCH] dup_task_struct can be static

Hi Linus,

[There may be lots of these depending on how bored I get :-)]

dup_task_struct is defined and used only in kernel/fork.c.

[This is not quite true, as arch/ia64/kernel/process.c also
defines a global dup_task_struct function, but I don't know
how it could ever be called.]

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

diff -ruN 2.5.23/kernel/fork.c 2.5.23-sfr.2/kernel/fork.c
--- 2.5.23/kernel/fork.c Wed Jun 19 12:41:51 2002
+++ 2.5.23-sfr.2/kernel/fork.c Thu Jun 20 12:03:27 2002
@@ -99,7 +99,7 @@
init_task.rlim[RLIMIT_NPROC].rlim_max = max_threads/2;
}

-struct task_struct *dup_task_struct(struct task_struct *orig)
+static struct task_struct *dup_task_struct(struct task_struct *orig)
{
struct task_struct *tsk;
struct thread_info *ti;

2002-06-20 06:18:47

by David Mosberger

Subject: Re: [PATCH] dup_task_struct can be static

>>>>> On Thu, 20 Jun 2002 12:18:13 +1000, Stephen Rothwell <[email protected]> said:

Stephen> Hi Linus,
Stephen> [There may be lots of these depending on how bored I get :-)]

Stephen> dup_task_struct is defined and used only in kernel/fork.c.

Stephen> [This is not quite true, as arch/ia64/kernel/process.c also
Stephen> defines a global dup_task_struct function, but I don't know
Stephen> how it could ever be called.]

It does---once you apply a small patch by David Howells which hasn't
made it into Linus' tree yet.

--david