device_unregister will call put_device,
so remove the redundant put_device
Signed-off-by: Ding Xiang <[email protected]>
---
drivers/spi/spi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 75ac046..d753689 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2133,11 +2133,9 @@ static ssize_t spi_slave_store(struct device *dev,
return -EINVAL;
child = device_find_child(&ctlr->dev, NULL, match_true);
- if (child) {
+ if (child)
/* Remove registered slave */
device_unregister(child);
- put_device(child);
- }
if (strcmp(name, "(null)")) {
/* Register new slave */
--
1.9.1
On Wed, Jul 17, 2019 at 06:05:44PM +0800, Ding Xiang wrote:
> device_unregister will call put_device,
> so remove the redundant put_device
> child = device_find_child(&ctlr->dev, NULL, match_true);
> - if (child) {
> + if (child)
> /* Remove registered slave */
> device_unregister(child);
> - put_device(child);
> - }
That's to undo the extra get we have from device_find_child(),
not to undo part of the registration.