Add devicetree bindings for i.MX6 UL/ULL based phyCORE-i.MX6 UL/ULL and
phyBOARD-Segin.
Signed-off-by: Stefan Riedmueller <[email protected]>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 7294ac36f4c0..40f007859092 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -161,12 +161,20 @@ properties:
items:
- enum:
- fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board
+ - phytec,imx6ul-pbacd10 # PHYTEC phyBOARD-Segin with i.MX6 UL
+ - phytec,imx6ul-pbacd10-emmc # PHYTEC phyBOARD-Segin eMMC Kit
+ - phytec,imx6ul-pbacd10-nand # PHYTEC phyBOARD-Segin NAND Kit
+ - phytec,imx6ul-pcl063 # PHYTEC phyCORE-i.MX 6UL
- const: fsl,imx6ul
- description: i.MX6ULL based Boards
items:
- enum:
- fsl,imx6ull-14x14-evk # i.MX6 UltraLiteLite 14x14 EVK Board
+ - phytec,imx6ull-pbacd10 # PHYTEC phyBOARD-Segin with i.MX6 ULL
+ - phytec,imx6ull-pbacd10-emmc # PHYTEC phyBOARD-Segin eMMC Kit
+ - phytec,imx6ull-pbacd10-nand # PHYTEC phyBOARD-Segin NAND Kit
+ - phytec,imx6ull-pcl063 # PHYTEC phyCORE-i.MX 6ULL
- const: fsl,imx6ull
- description: i.MX6ULZ based Boards
--
2.7.4
Add devicetree bindings for i.MX6 based phyCORE-i.MX6, phyBOARD-Mira and
phyFLEX-i.MX6.
Signed-off-by: Stefan Riedmueller <[email protected]>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 40f007859092..00a037cf5c86 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -112,6 +112,13 @@ properties:
- fsl,imx6q-sabreauto
- fsl,imx6q-sabrelite
- fsl,imx6q-sabresd
+ - phytec,imx6qdl-pcm058 # PHYTEC phyCORE-i.MX6
+ - phytec,imx6q-pbab01 # PHYTEC phyFLEX carrier board
+ - phytec,imx6q-pbab01-nand # PHYTEC phyFLEX eval Kit
+ - phytec,imx6q-pbac06 # PHYTEC phyBOARD-Mira with i.MX6 Quad
+ - phytec,imx6q-pbac06-emmc # PHYTEC phyBOARD-Mira eMMC RDK
+ - phytec,imx6q-pbac06-nand # PHYTEC phyBOARD-Mira NAND RDK
+ - phytec,imx6q-pfla02 # PHYTEC phyFLEX-i.MX6 Quad
- technologic,imx6q-ts4900
- technologic,imx6q-ts7970
- const: fsl,imx6q
@@ -121,6 +128,9 @@ properties:
- enum:
- fsl,imx6qp-sabreauto # i.MX6 Quad Plus SABRE Automotive Board
- fsl,imx6qp-sabresd # i.MX6 Quad Plus SABRE Smart Device Board
+ - phytec,imx6qdl-pcm058 # PHYTEC phyCORE-i.MX6
+ - phytec,imx6qp-pbac06 # PHYTEC phyBOARD-Mira with i.MX6 QuadPlus
+ - phytec,imx6qp-pbac06-nand # PHYTEC phyBOARD-Mira NAND RDK
- const: fsl,imx6qp
- description: i.MX6DL based Boards
@@ -131,6 +141,13 @@ properties:
- emtrion,emcon-mx6-avari # emCON-MX6S or emCON-MX6DL SoM on Avari Base
- fsl,imx6dl-sabreauto # i.MX6 DualLite/Solo SABRE Automotive Board
- fsl,imx6dl-sabresd # i.MX6 DualLite SABRE Smart Device Board
+ - phytec,imx6qdl-pcm058 # PHYTEC phyCORE-i.MX6
+ - phytec,imx6dl-pbab01 # PHYTEC phyFLEX carrier board
+ - phytec,imx6dl-pbab01-nand # PHYTEC phyFLEX eval Kit
+ - phytec,imx6dl-pbac06 # PHYTEC phyBOARD-Mira with i.MX6 DL
+ - phytec,imx6dl-pbac06-emmc # PHYTEC phyBOARD-Mira eMMC RDK
+ - phytec,imx6dl-pbac06-nand # PHYTEC phyBOARD-Mira NAND RDK
+ - phytec,imx6dl-pfla02 # PHYTEC phyFLEX-i.MX6 DL
- technologic,imx6dl-ts4900
- technologic,imx6dl-ts7970
- ysoft,imx6dl-yapp4-draco # i.MX6 DualLite Y Soft IOTA Draco board
--
2.7.4
On Wed, Jul 24, 2019 at 09:49:32AM +0200, Stefan Riedmueller wrote:
> Add devicetree bindings for i.MX6 UL/ULL based phyCORE-i.MX6 UL/ULL and
> phyBOARD-Segin.
>
> Signed-off-by: Stefan Riedmueller <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 7294ac36f4c0..40f007859092 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -161,12 +161,20 @@ properties:
> items:
> - enum:
> - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board
> + - phytec,imx6ul-pbacd10 # PHYTEC phyBOARD-Segin with i.MX6 UL
> + - phytec,imx6ul-pbacd10-emmc # PHYTEC phyBOARD-Segin eMMC Kit
> + - phytec,imx6ul-pbacd10-nand # PHYTEC phyBOARD-Segin NAND Kit
> + - phytec,imx6ul-pcl063 # PHYTEC phyCORE-i.MX 6UL
This doesn't match what is in the dts files:
arch/arm/boot/dts/imx6ul-phytec-pcl063.dtsi: compatible = "phytec,imx6ul-pcl063", "fsl,imx6ul";
arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts: compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul-pcl063",
"fsl,imx6ul";
arch/arm/boot/dts/imx6ul-phytec-phyboard-segin.dtsi: compatible = "phytec,imx6ul-pbacd-10", "phytec,imx6ul-pcl063",
"fsl,imx6ul";
> - const: fsl,imx6ul
>
> - description: i.MX6ULL based Boards
> items:
> - enum:
> - fsl,imx6ull-14x14-evk # i.MX6 UltraLiteLite 14x14 EVK Board
> + - phytec,imx6ull-pbacd10 # PHYTEC phyBOARD-Segin with i.MX6 ULL
> + - phytec,imx6ull-pbacd10-emmc # PHYTEC phyBOARD-Segin eMMC Kit
> + - phytec,imx6ull-pbacd10-nand # PHYTEC phyBOARD-Segin NAND Kit
> + - phytec,imx6ull-pcl063 # PHYTEC phyCORE-i.MX 6ULL
> - const: fsl,imx6ull
>
> - description: i.MX6ULZ based Boards
> --
> 2.7.4
>
Hi Rob,
On 13.08.19 18:04, Rob Herring wrote:
> On Wed, Jul 24, 2019 at 09:49:32AM +0200, Stefan Riedmueller wrote:
>> Add devicetree bindings for i.MX6 UL/ULL based phyCORE-i.MX6 UL/ULL and
>> phyBOARD-Segin.
>>
>> Signed-off-by: Stefan Riedmueller <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 7294ac36f4c0..40f007859092 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -161,12 +161,20 @@ properties:
>> items:
>> - enum:
>> - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board
>> + - phytec,imx6ul-pbacd10 # PHYTEC phyBOARD-Segin with i.MX6 UL
>> + - phytec,imx6ul-pbacd10-emmc # PHYTEC phyBOARD-Segin eMMC Kit
>> + - phytec,imx6ul-pbacd10-nand # PHYTEC phyBOARD-Segin NAND Kit
>> + - phytec,imx6ul-pcl063 # PHYTEC phyCORE-i.MX 6UL
>
> This doesn't match what is in the dts files:
>
> arch/arm/boot/dts/imx6ul-phytec-pcl063.dtsi: compatible = "phytec,imx6ul-pcl063", "fsl,imx6ul";
> arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts: compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul-pcl063",
> "fsl,imx6ul";
> arch/arm/boot/dts/imx6ul-phytec-phyboard-segin.dtsi: compatible = "phytec,imx6ul-pbacd-10", "phytec,imx6ul-pcl063",
> "fsl,imx6ul";
Shawn already applied my patches which rename the compatibles, see
https://lkml.org/lkml/2019/7/23/42
Maybe I was a little too fast sending this patch.
Stefan
>
>> - const: fsl,imx6ul
>>
>> - description: i.MX6ULL based Boards
>> items:
>> - enum:
>> - fsl,imx6ull-14x14-evk # i.MX6 UltraLiteLite 14x14 EVK Board
>> + - phytec,imx6ull-pbacd10 # PHYTEC phyBOARD-Segin with i.MX6 ULL
>> + - phytec,imx6ull-pbacd10-emmc # PHYTEC phyBOARD-Segin eMMC Kit
>> + - phytec,imx6ull-pbacd10-nand # PHYTEC phyBOARD-Segin NAND Kit
>> + - phytec,imx6ull-pcl063 # PHYTEC phyCORE-i.MX 6ULL
>> - const: fsl,imx6ull
>>
>> - description: i.MX6ULZ based Boards
>> --
>> 2.7.4
>>
On Thu, Aug 15, 2019 at 4:55 AM Stefan Riedmüller
<[email protected]> wrote:
>
> Hi Rob,
>
> On 13.08.19 18:04, Rob Herring wrote:
> > On Wed, Jul 24, 2019 at 09:49:32AM +0200, Stefan Riedmueller wrote:
> >> Add devicetree bindings for i.MX6 UL/ULL based phyCORE-i.MX6 UL/ULL and
> >> phyBOARD-Segin.
> >>
> >> Signed-off-by: Stefan Riedmueller <[email protected]>
> >> ---
> >> Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> >> index 7294ac36f4c0..40f007859092 100644
> >> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> >> @@ -161,12 +161,20 @@ properties:
> >> items:
> >> - enum:
> >> - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board
> >> + - phytec,imx6ul-pbacd10 # PHYTEC phyBOARD-Segin with i.MX6 UL
> >> + - phytec,imx6ul-pbacd10-emmc # PHYTEC phyBOARD-Segin eMMC Kit
> >> + - phytec,imx6ul-pbacd10-nand # PHYTEC phyBOARD-Segin NAND Kit
> >> + - phytec,imx6ul-pcl063 # PHYTEC phyCORE-i.MX 6UL
> >
> > This doesn't match what is in the dts files:
> >
> > arch/arm/boot/dts/imx6ul-phytec-pcl063.dtsi: compatible = "phytec,imx6ul-pcl063", "fsl,imx6ul";
> > arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts: compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul-pcl063",
> > "fsl,imx6ul";
> > arch/arm/boot/dts/imx6ul-phytec-phyboard-segin.dtsi: compatible = "phytec,imx6ul-pbacd-10", "phytec,imx6ul-pcl063",
> > "fsl,imx6ul";
>
> Shawn already applied my patches which rename the compatibles, see
> https://lkml.org/lkml/2019/7/23/42
In any case, it still doesn't match. For example, from those patches:
+ model = "PHYTEC phyBOARD-Segin i.MX6 ULL Full Featured with eMMC";
+ compatible = "phytec,imx6ull-pbacd10-emmc", "phytec,imx6ull-pbacd10",
+ "phytec,imx6ull-pcl063","fsl,imx6ull";
The correct schema for this would be:
items:
- const: phytec,imx6ull-pbacd10-emmc
- const: phytec,imx6ull-pbacd10
- const: phytec,imx6ull-pcl063
- const: fsl,imx6ull
This defines how many entries (4), what they are, and the order of
them. Maybe the first entry can be an enum with the -nand compatible
if those are 2 options.
Run 'make dtbs_check' and make sure there aren't warnings for the root node.
Rob
Hi Rob,
On 15.08.19 15:43, Rob Herring wrote:
> On Thu, Aug 15, 2019 at 4:55 AM Stefan Riedmüller
> <[email protected]> wrote:
>>
>> Hi Rob,
>>
>> On 13.08.19 18:04, Rob Herring wrote:
>>> On Wed, Jul 24, 2019 at 09:49:32AM +0200, Stefan Riedmueller wrote:
>>>> Add devicetree bindings for i.MX6 UL/ULL based phyCORE-i.MX6 UL/ULL and
>>>> phyBOARD-Segin.
>>>>
>>>> Signed-off-by: Stefan Riedmueller <[email protected]>
>>>> ---
>>>> Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++
>>>> 1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>>> index 7294ac36f4c0..40f007859092 100644
>>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>>> @@ -161,12 +161,20 @@ properties:
>>>> items:
>>>> - enum:
>>>> - fsl,imx6ul-14x14-evk # i.MX6 UltraLite 14x14 EVK Board
>>>> + - phytec,imx6ul-pbacd10 # PHYTEC phyBOARD-Segin with i.MX6 UL
>>>> + - phytec,imx6ul-pbacd10-emmc # PHYTEC phyBOARD-Segin eMMC Kit
>>>> + - phytec,imx6ul-pbacd10-nand # PHYTEC phyBOARD-Segin NAND Kit
>>>> + - phytec,imx6ul-pcl063 # PHYTEC phyCORE-i.MX 6UL
>>>
>>> This doesn't match what is in the dts files:
>>>
>>> arch/arm/boot/dts/imx6ul-phytec-pcl063.dtsi: compatible = "phytec,imx6ul-pcl063", "fsl,imx6ul";
>>> arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts: compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul-pcl063",
>>> "fsl,imx6ul";
>>> arch/arm/boot/dts/imx6ul-phytec-phyboard-segin.dtsi: compatible = "phytec,imx6ul-pbacd-10", "phytec,imx6ul-pcl063",
>>> "fsl,imx6ul";
>>
>> Shawn already applied my patches which rename the compatibles, see
>> https://lkml.org/lkml/2019/7/23/42
>
> In any case, it still doesn't match. For example, from those patches:
>
> + model = "PHYTEC phyBOARD-Segin i.MX6 ULL Full Featured with eMMC";
> + compatible = "phytec,imx6ull-pbacd10-emmc", "phytec,imx6ull-pbacd10",
> + "phytec,imx6ull-pcl063","fsl,imx6ull";
>
> The correct schema for this would be:
>
> items:
> - const: phytec,imx6ull-pbacd10-emmc
> - const: phytec,imx6ull-pbacd10
> - const: phytec,imx6ull-pcl063
> - const: fsl,imx6ull
>
> This defines how many entries (4), what they are, and the order of
> them. Maybe the first entry can be an enum with the -nand compatible
> if those are 2 options.
>
> Run 'make dtbs_check' and make sure there aren't warnings for the root node.
Thanks for your input. I will take another closer look at this and send a
new version.
Stefan
>
> Rob
>