2021-11-15 20:04:33

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH 5.10 011/575] scsi: core: Remove command size deduction from scsi_setup_scsi_cmnd()

On 11/15/21 8:55 AM, Greg Kroah-Hartman wrote:
> From: Tadeusz Struk <[email protected]>
>
> commit 703535e6ae1e94c89a9c1396b4c7b6b41160ef0c upstream.

Hi Greg,

Thanks for having queued this patch for the 5.10 stable branch.

Do you plan to also include commit 20aaef52eb08 ("scsi: scsi_ioctl:
Validate command size")? That patch prevents that the bug in the commit
mentioned above can be triggered.

Thanks,

Bart.


2021-11-15 23:47:56

by Tadeusz Struk

[permalink] [raw]
Subject: Re: [PATCH 5.10 011/575] scsi: core: Remove command size deduction from scsi_setup_scsi_cmnd()

On 11/15/21 09:58, Bart Van Assche wrote:
> Hi Greg,
>
> Thanks for having queued this patch for the 5.10 stable branch.
>
> Do you plan to also include commit 20aaef52eb08 ("scsi: scsi_ioctl: Validate
> command size")? That patch prevents that the bug in the commit mentioned above
> can be triggered.
>
> Thanks,

Hi Brad,
The "scsi_ioctl: Validate command size" patch is not needed for either 5.10 nor
5.14 as the it is set directly from COMMAND_SIZE(opcode). See:

https://elixir.bootlin.com/linux/v5.14.18/source/block/scsi_ioctl.c#L445
https://elixir.bootlin.com/linux/v5.10.79/source/block/scsi_ioctl.c#L447

--
Thanks,
Tadeusz

2021-11-16 00:03:50

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.10 011/575] scsi: core: Remove command size deduction from scsi_setup_scsi_cmnd()

On Mon, Nov 15, 2021 at 09:58:19AM -0800, Bart Van Assche wrote:
> On 11/15/21 8:55 AM, Greg Kroah-Hartman wrote:
> > From: Tadeusz Struk <[email protected]>
> >
> > commit 703535e6ae1e94c89a9c1396b4c7b6b41160ef0c upstream.
>
> Hi Greg,
>
> Thanks for having queued this patch for the 5.10 stable branch.
>
> Do you plan to also include commit 20aaef52eb08 ("scsi: scsi_ioctl: Validate
> command size")? That patch prevents that the bug in the commit mentioned
> above can be triggered.

It did not apply to 5.10.y and 5.14.y and a "FAILED:" email was sent out
asking for a backport of it.

If you can provide that, great, I'll be glad to take it.

thanks,

greg k-h