2019-08-06 10:19:29

by Rayagonda Kokatanur

[permalink] [raw]
Subject: [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode

Switch back to BSPI mode after MSPI operations (write and erase)
are completed. This change will keep qpsi in BSPI mode by default.

Signed-off-by: Rayagonda Kokatanur <[email protected]>
---
drivers/spi/spi-bcm-qspi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c
index 902bdbf..46a811a 100644
--- a/drivers/spi/spi-bcm-qspi.c
+++ b/drivers/spi/spi-bcm-qspi.c
@@ -897,6 +897,7 @@ static int bcm_qspi_transfer_one(struct spi_master *master,

read_from_hw(qspi, slots);
}
+ bcm_qspi_enable_bspi(qspi);

return 0;
}
--
1.9.1


2019-08-06 12:17:11

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode

On Tue, Aug 06, 2019 at 03:44:34PM +0530, Rayagonda Kokatanur wrote:
> Switch back to BSPI mode after MSPI operations (write and erase)
> are completed. This change will keep qpsi in BSPI mode by default.

Why?


Attachments:
(No filename) (216.00 B)
signature.asc (499.00 B)
Download all attachments

2019-08-27 13:03:23

by Kamal Dasu

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode

The spi-nor controller defaults to BSPI mode. So its being put to its
default mode.


Kamal

On Tue, Aug 6, 2019 at 8:16 AM Mark Brown <[email protected]> wrote:
>
> On Tue, Aug 06, 2019 at 03:44:34PM +0530, Rayagonda Kokatanur wrote:
> > Switch back to BSPI mode after MSPI operations (write and erase)
> > are completed. This change will keep qpsi in BSPI mode by default.
>
> Why?

2019-08-28 13:10:35

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode

On Tue, Aug 27, 2019 at 09:01:42AM -0400, Kamal Dasu wrote:

Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> The spi-nor controller defaults to BSPI mode. So its being put to its
> default mode.

The changelog should explain this.


Attachments:
(No filename) (437.00 B)
signature.asc (499.00 B)
Download all attachments