2019-08-24 16:13:02

by Souptick Joarder

Subject: [RESEND PATCH] perf: Remove duplicate headers

Removed duplicate headers which are included twice.

Signed-off-by: Souptick Joarder <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>
---
tools/perf/util/data.c | 1 -
tools/perf/util/get_current_dir_name.c | 1 -
tools/perf/util/stat-display.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
index 6a64f71..509a41e 100644
--- a/tools/perf/util/data.c
+++ b/tools/perf/util/data.c
@@ -8,7 +8,6 @@
#include <unistd.h>
#include <string.h>
#include <asm/bug.h>
-#include <sys/types.h>
#include <dirent.h>

#include "data.h"
diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
index 267aa60..ebb80cd 100644
--- a/tools/perf/util/get_current_dir_name.c
+++ b/tools/perf/util/get_current_dir_name.c
@@ -5,7 +5,6 @@
#include "util.h"
#include <unistd.h>
#include <stdlib.h>
-#include <stdlib.h>

/* Android's 'bionic' library, for one, doesn't have this */

diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 6d043c7..7b3a16c 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -12,7 +12,6 @@
#include "string2.h"
#include "sane_ctype.h"
#include "cgroup.h"
-#include <math.h>
#include <api/fs/fs.h>

#define CNTR_NOT_SUPPORTED "<not supported>"
--
1.9.1

2019-08-25 14:22:18

by Arnaldo Carvalho de Melo

Subject: Re: [RESEND PATCH] perf: Remove duplicate headers

Em Sat, Aug 24, 2019 at 09:45:19PM +0530, Souptick Joarder escreveu:
> Removed duplicate headers which are included twice.
>
> Signed-off-by: Souptick Joarder <[email protected]>
> Reviewed-by: Mukesh Ojha <[email protected]>

Thanks, applied.

- Arnaldo

> ---
> tools/perf/util/data.c | 1 -
> tools/perf/util/get_current_dir_name.c | 1 -
> tools/perf/util/stat-display.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index 6a64f71..509a41e 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -8,7 +8,6 @@
> #include <unistd.h>
> #include <string.h>
> #include <asm/bug.h>
> -#include <sys/types.h>
> #include <dirent.h>
>
> #include "data.h"
> diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> index 267aa60..ebb80cd 100644
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -5,7 +5,6 @@
> #include "util.h"
> #include <unistd.h>
> #include <stdlib.h>
> -#include <stdlib.h>
>
> /* Android's 'bionic' library, for one, doesn't have this */
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 6d043c7..7b3a16c 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -12,7 +12,6 @@
> #include "string2.h"
> #include "sane_ctype.h"
> #include "cgroup.h"
> -#include <math.h>
> #include <api/fs/fs.h>
>
> #define CNTR_NOT_SUPPORTED "<not supported>"
> --
> 1.9.1

--

- Arnaldo

2019-08-27 08:29:23

by tip-bot2 for Alexey Makhalov

Subject: [tip: perf/core] perf tools: Remove duplicate headers

The following commit has been merged into the perf/core branch of tip:

Commit-ID: b4de344b25b9fbd4db7b84da43808a6b7daac887
Gitweb: https://git.kernel.org/tip/b4de344b25b9fbd4db7b84da43808a6b7daac887
Author: Souptick Joarder <[email protected]>
AuthorDate: Sat, 24 Aug 2019 21:45:19 +05:30
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Mon, 26 Aug 2019 11:58:29 -03:00

perf tools: Remove duplicate headers

Removed headers which are included twice.

Signed-off-by: Souptick Joarder <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/util/data.c | 1 -
tools/perf/util/get_current_dir_name.c | 1 -
tools/perf/util/stat-display.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
index 1d1b97a..74aafe0 100644
--- a/tools/perf/util/data.c
+++ b/tools/perf/util/data.c
@@ -9,7 +9,6 @@
#include <unistd.h>
#include <string.h>
#include <asm/bug.h>
-#include <sys/types.h>
#include <dirent.h>

#include "data.h"
diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
index 01f32f2..b205d92 100644
--- a/tools/perf/util/get_current_dir_name.c
+++ b/tools/perf/util/get_current_dir_name.c
@@ -5,7 +5,6 @@
#include "get_current_dir_name.h"
#include <unistd.h>
#include <stdlib.h>
-#include <stdlib.h>

/* Android's 'bionic' library, for one, doesn't have this */

diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
index 51d6781..1461dac 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -14,7 +14,6 @@
#include "string2.h"
#include <linux/ctype.h>
#include "cgroup.h"
-#include <math.h>
#include <api/fs/fs.h>

#define CNTR_NOT_SUPPORTED "<not supported>"