2019-09-04 14:06:07

by Harini Katakam

[permalink] [raw]
Subject: [PATCH v2 0/2] Fix GMII2RGMII private field

Fix the usage of external phy's priv field by gmii2rgmii driver.

Based on net-next.

Harini Katakam (2):
include: mdio: Add driver data helpers
net: phy: gmii2rgmii: Dont use priv field in phy device

drivers/net/phy/xilinx_gmii2rgmii.c | 4 ++--
include/linux/mdio.h | 11 +++++++++++
2 files changed, 13 insertions(+), 2 deletions(-)

--
2.7.4


2019-09-04 14:06:08

by Harini Katakam

[permalink] [raw]
Subject: [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device

Use set/get drv data in phydev's mdio device instead. Phy device priv
field maybe used by the external phy driver and should not be
overwritten.

Signed-off-by: Harini Katakam <[email protected]>
---
v2:
Use mdio driver data helper.

drivers/net/phy/xilinx_gmii2rgmii.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index 2d14493..151c2a3 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -29,7 +29,7 @@ struct gmii2rgmii {

static int xgmiitorgmii_read_status(struct phy_device *phydev)
{
- struct gmii2rgmii *priv = phydev->priv;
+ struct gmii2rgmii *priv = mdiodev_get_drvdata(&phydev->mdio);
struct mii_bus *bus = priv->mdio->bus;
int addr = priv->mdio->addr;
u16 val = 0;
@@ -90,7 +90,7 @@ static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
memcpy(&priv->conv_phy_drv, priv->phy_dev->drv,
sizeof(struct phy_driver));
priv->conv_phy_drv.read_status = xgmiitorgmii_read_status;
- priv->phy_dev->priv = priv;
+ mdiodev_set_drvdata(&priv->phy_dev->mdio, priv);
priv->phy_dev->drv = &priv->conv_phy_drv;

return 0;
--
2.7.4

2019-09-04 16:49:03

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device

On Wed, Sep 04, 2019 at 07:30:21PM +0530, Harini Katakam wrote:
> Use set/get drv data in phydev's mdio device instead. Phy device priv
> field maybe used by the external phy driver and should not be
> overwritten.
>
> Signed-off-by: Harini Katakam <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2019-09-04 17:12:25

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] net: phy: gmii2rgmii: Dont use priv field in phy device

On 9/4/19 7:00 AM, Harini Katakam wrote:
> Use set/get drv data in phydev's mdio device instead. Phy device priv
> field maybe used by the external phy driver and should not be
> overwritten.
>
> Signed-off-by: Harini Katakam <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2019-09-05 12:33:04

by David Miller

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Fix GMII2RGMII private field

From: Harini Katakam <[email protected]>
Date: Wed, 4 Sep 2019 19:30:19 +0530

> Fix the usage of external phy's priv field by gmii2rgmii driver.
>
> Based on net-next.

Series applied to net-next.