2019-09-05 03:52:13

by Masahiro Yamada

Subject: [PATCH] irqchip: uniphier-aidet: use devm_platform_ioremap_resource()

Replace the chain of platform_get_resource() and devm_ioremap_resource()
with devm_platform_ioremap_resource().

This allows to remove the local variable for (struct resource *), and
have one function call less.

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/irqchip/irq-uniphier-aidet.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-uniphier-aidet.c b/drivers/irqchip/irq-uniphier-aidet.c
index ed7b4f47ff3f..89121b39be26 100644
--- a/drivers/irqchip/irq-uniphier-aidet.c
+++ b/drivers/irqchip/irq-uniphier-aidet.c
@@ -166,7 +166,6 @@ static int uniphier_aidet_probe(struct platform_device *pdev)
struct device_node *parent_np;
struct irq_domain *parent_domain;
struct uniphier_aidet_priv *priv;
- struct resource *res;

parent_np = of_irq_find_parent(dev->of_node);
if (!parent_np)
@@ -181,8 +180,7 @@ static int uniphier_aidet_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->reg_base = devm_ioremap_resource(dev, res);
+ priv->reg_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->reg_base))
return PTR_ERR(priv->reg_base);

--
2.17.1

2019-09-05 08:57:29

by Marc Zyngier

Subject: Re: [PATCH] irqchip: uniphier-aidet: use devm_platform_ioremap_resource()

On Thu, 05 Sep 2019 04:49:32 +0100,
Masahiro Yamada <[email protected]> wrote:
>
> Replace the chain of platform_get_resource() and devm_ioremap_resource()
> with devm_platform_ioremap_resource().
>
> This allows to remove the local variable for (struct resource *), and
> have one function call less.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> drivers/irqchip/irq-uniphier-aidet.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied to irqchip-next.

Thanks,

M.

--
Jazz is not dead, it just smells funny.

2019-09-06 17:02:02

by tip-bot2 for Alexey Makhalov

Subject: [tip: irq/core] irqchip/uniphier-aidet: Use devm_platform_ioremap_resource()

The following commit has been merged into the irq/core branch of tip:

Commit-ID: e89327f659dd517f30b6232b1fabd6f6c6777c3e
Gitweb: https://git.kernel.org/tip/e89327f659dd517f30b6232b1fabd6f6c6777c3e
Author: Masahiro Yamada <[email protected]>
AuthorDate: Thu, 05 Sep 2019 12:49:32 +09:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Thu, 05 Sep 2019 09:28:13 +01:00

irqchip/uniphier-aidet: Use devm_platform_ioremap_resource()

Replace the chain of platform_get_resource() and devm_ioremap_resource()
with devm_platform_ioremap_resource().

This allows to remove the local variable for (struct resource *), and
have one function call less.

Signed-off-by: Masahiro Yamada <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-uniphier-aidet.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-uniphier-aidet.c b/drivers/irqchip/irq-uniphier-aidet.c
index ed7b4f4..89121b3 100644
--- a/drivers/irqchip/irq-uniphier-aidet.c
+++ b/drivers/irqchip/irq-uniphier-aidet.c
@@ -166,7 +166,6 @@ static int uniphier_aidet_probe(struct platform_device *pdev)
struct device_node *parent_np;
struct irq_domain *parent_domain;
struct uniphier_aidet_priv *priv;
- struct resource *res;

parent_np = of_irq_find_parent(dev->of_node);
if (!parent_np)
@@ -181,8 +180,7 @@ static int uniphier_aidet_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->reg_base = devm_ioremap_resource(dev, res);
+ priv->reg_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->reg_base))
return PTR_ERR(priv->reg_base);