2019-09-10 18:52:53

by tiantao (H)

[permalink] [raw]
Subject: [PATCH] ras: debugfs: Fix warning: no previous prototype

fixed the fellow warning when building with warnings enabled (W=1)

drivers/ras/debugfs.c:8:5: warning: no previous prototype for
‘ras_userspace_consumers’ [-Wmissing-prototypes]
int ras_userspace_consumers(void)

drivers/ras/debugfs.c:38:12: warning: no previous prototype for
‘ras_add_daemon_trace’ [-Wmissing-prototypes]
int __init ras_add_daemon_trace(void)

drivers/ras/debugfs.c:54:13: warning: no previous prototype for
‘ras_debugfs_init’ [-Wmissing-prototypes]
void __init ras_debugfs_init(void)

Signed-off-by: tiantao6 <[email protected]>
---
drivers/ras/debugfs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c
index 9c1b717..39b96a5 100644
--- a/drivers/ras/debugfs.c
+++ b/drivers/ras/debugfs.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
#include <linux/debugfs.h>
+#include <linux/ras.h>

struct dentry *ras_debugfs_dir;

--
2.7.4


2019-09-10 18:53:13

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH] ras: debugfs: Fix warning: no previous prototype

On Tue, Sep 10, 2019 at 04:22:19PM +0800, tiantao6 wrote:
> fixed the fellow warning when building with warnings enabled (W=1)

"fellow"?

>
> drivers/ras/debugfs.c:8:5: warning: no previous prototype for
> ‘ras_userspace_consumers’ [-Wmissing-prototypes]
> int ras_userspace_consumers(void)
>
> drivers/ras/debugfs.c:38:12: warning: no previous prototype for
> ‘ras_add_daemon_trace’ [-Wmissing-prototypes]
> int __init ras_add_daemon_trace(void)
>
> drivers/ras/debugfs.c:54:13: warning: no previous prototype for
> ‘ras_debugfs_init’ [-Wmissing-prototypes]
> void __init ras_debugfs_init(void)

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=ras/core&id=0a54b809a3a2c31e1055b45b03708eb730222be1

>
> Signed-off-by: tiantao6 <[email protected]>

Also, if you intend to send more patches in the future, please use your
real name.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette