2019-09-26 08:43:06

by Hongwei Zhang

[permalink] [raw]
Subject: [v1, 0/1] gpio: dts: aspeed: Add SGPIO driver

Hello,

This short series introduce the Kconfig, Makefile, and dts for the
Aspeed AST2500 SGPIO controller. This is the last patch set.
Please review.

[v1]: Initial commit

The related SGPIO driver has been accepted and merged into v5.4:
_http://patchwork.ozlabs.org/patch/1150357/

The related SGPM pinmux dt-binding document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/

Thanks!
Hongwei Zhang (1):
gpio: dts: aspeed: Add SGPIO driver

arch/arm/Kconfig | 2 ++
arch/arm/boot/dts/aspeed-g5.dtsi | 16 +++++++++++++++-
drivers/gpio/Kconfig | 8 ++++++++
drivers/gpio/Makefile | 1 +
4 files changed, 26 insertions(+), 1 deletion(-)

--
2.7.4


2019-09-26 09:34:41

by Linus Walleij

[permalink] [raw]
Subject: Re: [v1, 0/1] gpio: dts: aspeed: Add SGPIO driver

On Tue, Sep 24, 2019 at 9:02 PM Hongwei Zhang <[email protected]> wrote:

> The related SGPIO driver has been accepted and merged into v5.4:
> _http://patchwork.ozlabs.org/patch/1150357/

Oh what a mess, it didn't add the necessary code into Kconfig
and Makefile, also names it sgpio-gpio.c when everything
else is named gpio-sgpio.c.

I guess I have to fix it up. My fault for missing.

Linus Walleij

2019-09-26 09:54:48

by Hongwei Zhang

[permalink] [raw]
Subject: [v1, 0/1] gpio: dts: aspeed: Add SGPIO driver

>
> > The related SGPIO driver has been accepted and merged into v5.4:
> > _http://patchwork.ozlabs.org/patch/1150357/
>
> Oh what a mess, it didn't add the necessary code into Kconfig and Makefile, also names it sgpio-gpio.c
> when everything else is named gpio-sgpio.c.
>
> I guess I have to fix it up. My fault for missing.
>
> Linus Walleij

Thanks Linus,

It's not your fault, I misunderstood a earlier comment from another
reviewer and thought I should wait until the driver is accecpted,
and then submit the patch to include / enable it.

As Bart suggested, I splitte the patches.

Regarding the driver name, following the gpio-SoC_name.o convention
in the Makefile, we choose sgpio-aspeed.o .

--Hongwei