2019-10-07 18:53:35

by Jolly Shah

[permalink] [raw]
Subject: [PATCH v2 0/2] drivers: firmware: xilinx: Add support for versal soc

Versal is xilinx's next generation soc. This patch adds
driver support required to be compatible with versal device

v2:
No changes. Resending to include DT maintaners

Jolly Shah (2):
dt-bindings: firmware: Add bindings for Versal firmware
drivers: firmware: xilinx: Add support for versal soc

.../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 +++++++++++++++-
drivers/firmware/xilinx/zynqmp.c | 8 ++++++--
2 files changed, 21 insertions(+), 3 deletions(-)

--
2.7.4


2019-10-07 18:54:08

by Jolly Shah

[permalink] [raw]
Subject: [PATCH v2 2/2] drivers: firmware: xilinx: Add support for versal soc

Versal is xilinx's next generation soc. This patch adds
driver support required to be compatible with versal device.

Signed-off-by: Jolly Shah <[email protected]>
---
drivers/firmware/xilinx/zynqmp.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index fd3d837..75bdfaa 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -711,8 +711,11 @@ static int zynqmp_firmware_probe(struct platform_device *pdev)
int ret;

np = of_find_compatible_node(NULL, NULL, "xlnx,zynqmp");
- if (!np)
- return 0;
+ if (!np) {
+ np = of_find_compatible_node(NULL, NULL, "xlnx,versal");
+ if (!np)
+ return 0;
+ }
of_node_put(np);

ret = get_set_conduit_method(dev->of_node);
@@ -770,6 +773,7 @@ static int zynqmp_firmware_remove(struct platform_device *pdev)

static const struct of_device_id zynqmp_firmware_of_match[] = {
{.compatible = "xlnx,zynqmp-firmware"},
+ {.compatible = "xlnx,versal-firmware"},
{},
};
MODULE_DEVICE_TABLE(of, zynqmp_firmware_of_match);
--
2.7.4

2019-10-07 18:55:04

by Jolly Shah

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: firmware: Add bindings for Versal firmware

ZynqMP firmware driver can be used for versal also.
Add versal compatible string to zynqmp firmware driver
doc.

Signed-off-by: Jolly Shah <[email protected]>
---
.../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
index a4fe136..18c3aea 100644
--- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
+++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
@@ -11,7 +11,9 @@ power management service, FPGA service and other platform management
services.

Required properties:
- - compatible: Must contain: "xlnx,zynqmp-firmware"
+ - compatible: Must contain any of below:
+ "xlnx,zynqmp-firmware" for Zynq Ultrascale+ MPSoC
+ "xlnx,versal-firmware" for Versal
- method: The method of calling the PM-API firmware layer.
Permitted values are:
- "smc" : SMC #0, following the SMCCC
@@ -21,6 +23,8 @@ Required properties:
Example
-------

+Zynq Ultrascale+ MPSoC
+----------------------
firmware {
zynqmp_firmware: zynqmp-firmware {
compatible = "xlnx,zynqmp-firmware";
@@ -28,3 +32,13 @@ firmware {
...
};
};
+
+Versal
+------
+firmware {
+ versal_firmware: versal-firmware {
+ compatible = "xlnx,versal-firmware";
+ method = "smc";
+ ...
+ };
+};
--
2.7.4

2019-10-11 16:56:35

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: firmware: Add bindings for Versal firmware

On Mon, 7 Oct 2019 11:52:22 -0700, Jolly Shah wrote:
> ZynqMP firmware driver can be used for versal also.
> Add versal compatible string to zynqmp firmware driver
> doc.
>
> Signed-off-by: Jolly Shah <[email protected]>
> ---
> .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>

Reviewed-by: Rob Herring <[email protected]>

2019-10-16 14:50:33

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] drivers: firmware: xilinx: Add support for versal soc

On 07. 10. 19 20:52, Jolly Shah wrote:
> Versal is xilinx's next generation soc. This patch adds
> driver support required to be compatible with versal device
>
> v2:
> No changes. Resending to include DT maintaners
>
> Jolly Shah (2):
> dt-bindings: firmware: Add bindings for Versal firmware
> drivers: firmware: xilinx: Add support for versal soc
>
> .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 +++++++++++++++-
> drivers/firmware/xilinx/zynqmp.c | 8 ++++++--
> 2 files changed, 21 insertions(+), 3 deletions(-)
>

Applied both.
I just removed drivers from subject of 2/2.

Thanks,
Michal