2019-10-10 06:35:52

by Yi Wang

[permalink] [raw]
Subject: [PATCH] x86/kvm: Fix -Wmissing-prototypes warnings

We get two warning when build kernel with W=1:
arch/x86/kernel/kvm.c:872:6: warning: no previous prototype for ‘arch_haltpoll_enable’ [-Wmissing-prototypes]
arch/x86/kernel/kvm.c:885:6: warning: no previous prototype for ‘arch_haltpoll_disable’ [-Wmissing-prototypes]

Including the missing head file can fix this.

Signed-off-by: Yi Wang <[email protected]>
---
arch/x86/kernel/kvm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index e820568..32ef1ee 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -33,6 +33,7 @@
#include <asm/apicdef.h>
#include <asm/hypervisor.h>
#include <asm/tlb.h>
+#include <asm/cpuidle_haltpoll.h>

static int kvmapf = 1;

--
1.8.3.1


2019-10-25 20:04:21

by Paolo Bonzini

[permalink] [raw]
Subject: Re: [PATCH] x86/kvm: Fix -Wmissing-prototypes warnings

Queued, thanks. It may not appear on git.kernel.org until after KVM
Forum though.

Paolo

On 25/10/19 03:58, [email protected] wrote:
> Gentle Ping :)
>
>> We get two warning when build kernel with W=1:
>> arch/x86/kernel/kvm.c:872:6: warning: no previous prototype for ‘arch_haltpoll_enable’ [-Wmissing-prototypes]
>> arch/x86/kernel/kvm.c:885:6: warning: no previous prototype for ‘arch_haltpoll_disable’ [-Wmissing-prototypes]
>>
>> Including the missing head file can fix this.
>>
>> Signed-off-by: Yi Wang <[email protected]>
>> ---
>> arch/x86/kernel/kvm.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
>> index e820568..32ef1ee 100644
>> --- a/arch/x86/kernel/kvm.c
>> +++ b/arch/x86/kernel/kvm.c
>> @@ -33,6 +33,7 @@
>> #include <asm/apicdef.h>
>> #include <asm/hypervisor.h>
>> #include <asm/tlb.h>
>> +#include <asm/cpuidle_haltpoll.h>
>>
>> static int kvmapf = 1;
>
>
> ---
> Best wishes
> Yi Wang
>