2019-10-25 19:20:05

by zhongshiqi

Subject: [PATCH v3] coccicheck: Support search for SmPL scripts within selected directory hierarchy

Allow defining COCCI as a directory to search SmPL scripts. Start a
corresponding file determination if the environment variable “COCCI”
contains an acceptable path.

Signed-off-by: zhongshiqi <[email protected]>
---
Changes in v3:
1:rewrite change description
2:fix patch subject
3:modify commit log

Changes in v2:
1.fix patch subject according to the reply by Markus
<[email protected]>
2.change description in “imperative mood”

scripts/coccicheck | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index e04d328..a1c4197 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -257,6 +257,10 @@ if [ "$COCCI" = "" ] ; then
for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
coccinelle $f
done
+elif [ -d "$COCCI" ] ; then
+ for f in `find $COCCI/ -name '*.cocci' -type f | sort`; do
+ coccinelle $f
+ done
else
coccinelle $COCCI
fi
--
2.9.5

2019-10-25 19:27:55

by Markus Elfring

Subject: Re: [PATCH v3] coccicheck: Support search for SmPL scripts within selected directory hierarchy

> Allow defining COCCI as a directory to search SmPL scripts. Start a
> corresponding file determination if the environment variable “COCCI”
> contains an acceptable path.

Can another wording fine-tuning matter for such a change description?

* Allow defining the environment variable “COCCI” as a directory
to search SmPL scripts.

* Start a corresponding file determination if it contains an acceptable path.

Regards,
Markus