2019-10-26 07:50:00

by zhongshiqi

[permalink] [raw]
Subject: [PATCH v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy

Allow defining the environment variable “COCCI” as a directory
to search SmPL scripts. Start a corresponding file determination
if it contains an acceptable path.

Signed-off-by: zhongshiqi <[email protected]>
---
Changes in v4:
1:rewrite change description in another wording

Changes in v3:
1:rewrite change description
2:fix patch subject
3:modify commit log

Changes in v2:
1.fix patch subject according to the reply by Markus
<[email protected]>
2.change description in “imperative mood”

scripts/coccicheck | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index e04d328..a1c4197 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -257,6 +257,10 @@ if [ "$COCCI" = "" ] ; then
for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
coccinelle $f
done
+elif [ -d "$COCCI" ] ; then
+ for f in `find $COCCI/ -name '*.cocci' -type f | sort`; do
+ coccinelle $f
+ done
else
coccinelle $COCCI
fi
--
2.9.5


2019-10-26 14:14:43

by Markus Elfring

[permalink] [raw]
Subject: Re: [PATCH v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy

> Allow defining the environment variable “COCCI” as a directory
> to search SmPL scripts. Start a corresponding file determination
> if it contains an acceptable path.

Would the paragraph formatting be nicer as an enumeration
as I suggested it previously?


Would you like to update the provided software documentation together with
the small extension of this bash script?

Update candidates:
*

* https://bottest.wiki.kernel.org/coccicheck#controlling_which_files_are_processed_by_coccinelle

Regards,
Markus

2019-10-26 14:24:05

by Markus Elfring

[permalink] [raw]
Subject: Re: [PATCH v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy

> Would you like to update the provided software documentation together with
> the small extension of this bash script?
>
> Update candidates:

Please reconsider also the section “Using Coccinelle with a single semantic patch”:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=f877bee5ea0b56c39cd0a243e113a577b5a4ef92#n151

Regards,
Markus