2019-11-04 09:13:50

by Zhenzhong Duan

[permalink] [raw]
Subject: [PATCH] moduleparam: fix parameter description mismatch

The first parameter of module_param is @name, but @value is used
in description. Fix it.

Fixes: 546970bc6afc ("param: add kerneldoc to moduleparam.h")
Signed-off-by: Zhenzhong Duan <[email protected]>
---
include/linux/moduleparam.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
index 5ba250d..e5c3e23 100644
--- a/include/linux/moduleparam.h
+++ b/include/linux/moduleparam.h
@@ -100,11 +100,11 @@ struct kparam_array

/**
* module_param - typesafe helper for a module/cmdline parameter
- * @value: the variable to alter, and exposed parameter name.
+ * @name: the variable to alter, and exposed parameter name.
* @type: the type of the parameter
* @perm: visibility in sysfs.
*
- * @value becomes the module parameter, or (prefixed by KBUILD_MODNAME and a
+ * @name becomes the module parameter, or (prefixed by KBUILD_MODNAME and a
* ".") the kernel commandline parameter. Note that - is changed to _, so
* the user can use "foo-bar=1" even for variable "foo_bar".
*
--
1.8.3.1


2019-11-07 14:17:01

by Jessica Yu

[permalink] [raw]
Subject: Re: [PATCH] moduleparam: fix parameter description mismatch

+++ Zhenzhong Duan [04/11/19 17:09 +0800]:
>The first parameter of module_param is @name, but @value is used
>in description. Fix it.
>
>Fixes: 546970bc6afc ("param: add kerneldoc to moduleparam.h")
>Signed-off-by: Zhenzhong Duan <[email protected]>

Applied, thanks.

Jessica