2019-11-04 15:40:23

by rishi gupta

Subject: [PATCH v6 2/3] dt-bindings: iio: light: add veml6030 ALS bindings

This commit adds device tree bindings for veml6030 ambient
light sensor.

Signed-off-by: Rishi Gupta <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
Changes in v6:
* None

Changes in v5:
* None

Changes in v4:
* Added enum in reg property
* Removed maxItems from reg property

Changes in v3:
* None

Changes in v2:
* Corrected grammatical mistake from 'is' to 'are' in description of bindings

.../devicetree/bindings/iio/light/veml6030.yaml | 62 ++++++++++++++++++++++
1 file changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml

diff --git a/Documentation/devicetree/bindings/iio/light/veml6030.yaml b/Documentation/devicetree/bindings/iio/light/veml6030.yaml
new file mode 100644
index 0000000..0ff9b11
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/veml6030.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: GPL-2.0+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/veml6030.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VEML6030 Ambient Light Sensor (ALS)
+
+maintainers:
+ - Rishi Gupta <[email protected]>
+
+description: |
+ Bindings for the ambient light sensor veml6030 from Vishay
+ Semiconductors over an i2c interface.
+
+ Irrespective of whether interrupt is used or not, application
+ can get the ALS and White channel reading from IIO raw interface.
+
+ If the interrupts are used, application will receive an IIO event
+ whenever configured threshold is crossed.
+
+ Specifications about the sensor can be found at:
+ https://www.vishay.com/docs/84366/veml6030.pdf
+
+properties:
+ compatible:
+ enum:
+ - vishay,veml6030
+
+ reg:
+ description:
+ I2C address of the device.
+ enum:
+ - 0x10 # ADDR pin pulled down
+ - 0x48 # ADDR pin pulled up
+
+ interrupts:
+ description:
+ interrupt mapping for IRQ. Configure with IRQ_TYPE_LEVEL_LOW.
+ Refer to interrupt-controller/interrupts.txt for generic
+ interrupt client node bindings.
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ light-sensor@10 {
+ compatible = "vishay,veml6030";
+ reg = <0x10>;
+ interrupts = <12 IRQ_TYPE_LEVEL_LOW>;
+ };
+ };
+...
--
2.7.4

2019-11-10 10:42:53

by Jonathan Cameron

Subject: Re: [PATCH v6 2/3] dt-bindings: iio: light: add veml6030 ALS bindings

On Mon, 4 Nov 2019 21:09:00 +0530
Rishi Gupta <[email protected]> wrote:

> This commit adds device tree bindings for veml6030 ambient
> light sensor.
>
> Signed-off-by: Rishi Gupta <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to possibly poke at it.
Not sure they actually do dt binding checks though and they pass locally
so that's probably irrelevant for now ;)

Thanks,

Jonathan

> ---
> Changes in v6:
> * None
>
> Changes in v5:
> * None
>
> Changes in v4:
> * Added enum in reg property
> * Removed maxItems from reg property
>
> Changes in v3:
> * None
>
> Changes in v2:
> * Corrected grammatical mistake from 'is' to 'are' in description of bindings
>
> .../devicetree/bindings/iio/light/veml6030.yaml | 62 ++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/light/veml6030.yaml b/Documentation/devicetree/bindings/iio/light/veml6030.yaml
> new file mode 100644
> index 0000000..0ff9b11
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/veml6030.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/veml6030.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VEML6030 Ambient Light Sensor (ALS)
> +
> +maintainers:
> + - Rishi Gupta <[email protected]>
> +
> +description: |
> + Bindings for the ambient light sensor veml6030 from Vishay
> + Semiconductors over an i2c interface.
> +
> + Irrespective of whether interrupt is used or not, application
> + can get the ALS and White channel reading from IIO raw interface.
> +
> + If the interrupts are used, application will receive an IIO event
> + whenever configured threshold is crossed.
> +
> + Specifications about the sensor can be found at:
> + https://www.vishay.com/docs/84366/veml6030.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - vishay,veml6030
> +
> + reg:
> + description:
> + I2C address of the device.
> + enum:
> + - 0x10 # ADDR pin pulled down
> + - 0x48 # ADDR pin pulled up
> +
> + interrupts:
> + description:
> + interrupt mapping for IRQ. Configure with IRQ_TYPE_LEVEL_LOW.
> + Refer to interrupt-controller/interrupts.txt for generic
> + interrupt client node bindings.
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + light-sensor@10 {
> + compatible = "vishay,veml6030";
> + reg = <0x10>;
> + interrupts = <12 IRQ_TYPE_LEVEL_LOW>;
> + };
> + };
> +...