2019-11-08 16:00:33

by Giovanni Gherdovich

Subject: [PATCH] checkpatch: remove "ipc" from list of expected toplevel directories

checkpatch.pl uses a list of expected directory names to understand if it's
being run from the top of a kernel tree. Commit 76128326f97c ("toplevel:
Move ipc/ to kernel/ipc/: move the files") removed a toplevel directory, so
checkpatch.pl need to update its list.

Signed-off-by: Giovanni Gherdovich <[email protected]>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6fcc66afb088..93b8fd1eea57 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1099,7 +1099,7 @@ sub top_of_kernel_tree {
my @tree_check = (
"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
"README", "Documentation", "arch", "include", "drivers",
- "fs", "init", "ipc", "kernel", "lib", "scripts",
+ "fs", "init", "kernel", "lib", "scripts",
);

foreach my $check (@tree_check) {
--
2.16.4

2019-11-08 16:23:21

by Giovanni Gherdovich

Subject: Re: [PATCH] checkpatch: remove "ipc" from list of expected toplevel directories

On Fri, 2019-11-08 at 17:04 +0100, Giovanni Gherdovich wrote:
> checkpatch.pl uses a list of expected directory names to understand if it's
> being run from the top of a kernel tree. Commit 76128326f97c ("toplevel:
> Move ipc/ to kernel/ipc/: move the files") removed a toplevel directory, so
> checkpatch.pl need to update its list.
>
> Signed-off-by: Giovanni Gherdovich <[email protected]>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6fcc66afb088..93b8fd1eea57 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1099,7 +1099,7 @@ sub top_of_kernel_tree {
> my @tree_check = (
> "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
> "README", "Documentation", "arch", "include", "drivers",
> - "fs", "init", "ipc", "kernel", "lib", "scripts",
> + "fs", "init", "kernel", "lib", "scripts",
> );
>
> foreach my $check (@tree_check) {

Nope, this was already fixed by Yunfeng Ye with
https://lore.kernel.org/lkml/[email protected]/
plus the ipc/ directory is now back in its place.

Sorry for the noise,
Giovanni