2019-11-08 23:41:56

by Elliot Berman

[permalink] [raw]
Subject: [PATCH v2 2/2] power: reset: Enable tristate on restart power-off driver

Since reboot_mode is an exported symbol, restart power-off driver can be
compiled as module.

Signed-off-by: Elliot Berman <[email protected]>
---
drivers/power/reset/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index a564237..8db1d9d 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -150,7 +150,7 @@ config POWER_RESET_QNAP
Say Y if you have a QNAP NAS.

config POWER_RESET_RESTART
- bool "Restart power-off driver"
+ tristate "Restart power-off driver"
help
Some boards don't actually have the ability to power off.
Instead they restart, and u-boot holds the SoC until the
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


2019-12-19 00:09:27

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] power: reset: Enable tristate on restart power-off driver

Hi,

On Fri, Nov 08, 2019 at 03:40:52PM -0800, Elliot Berman wrote:
> Since reboot_mode is an exported symbol, restart power-off driver can be
> compiled as module.
>
> Signed-off-by: Elliot Berman <[email protected]>
> ---

I tried applying this for 5.6, but it fails to build with
allmodconfig on arm:

ERROR: "machine_restart" [drivers/power/reset/restart-poweroff.ko] undefined!

-- Sebastian


Attachments:
(No filename) (418.00 B)
signature.asc (849.00 B)
Download all attachments