2019-10-23 08:38:09

by Leo Yan

[permalink] [raw]
Subject: [PATCH] perf tests: Fix a typo

Correct typo in comment: s/suck/stuck.

Signed-off-by: Leo Yan <[email protected]>
---
tools/perf/tests/bp_signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c
index 166f411568a5..415903b48578 100644
--- a/tools/perf/tests/bp_signal.c
+++ b/tools/perf/tests/bp_signal.c
@@ -295,7 +295,7 @@ bool test__bp_signal_is_supported(void)
* breakpointed instruction.
*
* Since arm64 has the same issue with arm for the single-step
- * handling, this case also gets suck on the breakpointed
+ * handling, this case also gets stuck on the breakpointed
* instruction.
*
* Just disable the test for these architectures until these
--
2.17.1


2019-10-23 09:15:55

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH] perf tests: Fix a typo

On Wed, Oct 23, 2019 at 04:33:24PM +0800, Leo Yan wrote:
> Correct typo in comment: s/suck/stuck.
>
> Signed-off-by: Leo Yan <[email protected]>
> ---
> tools/perf/tests/bp_signal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c
> index 166f411568a5..415903b48578 100644
> --- a/tools/perf/tests/bp_signal.c
> +++ b/tools/perf/tests/bp_signal.c
> @@ -295,7 +295,7 @@ bool test__bp_signal_is_supported(void)
> * breakpointed instruction.
> *
> * Since arm64 has the same issue with arm for the single-step
> - * handling, this case also gets suck on the breakpointed
> + * handling, this case also gets stuck on the breakpointed
> * instruction.
> *
> * Just disable the test for these architectures until these

Thanks, and sorry for only spotting this after the offending patch was
merged.

Will

2019-10-23 09:30:20

by Leo Yan

[permalink] [raw]
Subject: Re: [PATCH] perf tests: Fix a typo

On Wed, Oct 23, 2019 at 10:14:17AM +0100, Will Deacon wrote:
> On Wed, Oct 23, 2019 at 04:33:24PM +0800, Leo Yan wrote:
> > Correct typo in comment: s/suck/stuck.
> >
> > Signed-off-by: Leo Yan <[email protected]>
> > ---
> > tools/perf/tests/bp_signal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c
> > index 166f411568a5..415903b48578 100644
> > --- a/tools/perf/tests/bp_signal.c
> > +++ b/tools/perf/tests/bp_signal.c
> > @@ -295,7 +295,7 @@ bool test__bp_signal_is_supported(void)
> > * breakpointed instruction.
> > *
> > * Since arm64 has the same issue with arm for the single-step
> > - * handling, this case also gets suck on the breakpointed
> > + * handling, this case also gets stuck on the breakpointed
> > * instruction.
> > *
> > * Just disable the test for these architectures until these
>
> Thanks, and sorry for only spotting this after the offending patch was
> merged.

No worries and thanks for review.

Subject: [tip: perf/core] perf tests: Fix a typo

The following commit has been merged into the perf/core branch of tip:

Commit-ID: b7dc21f546d854aea75245efd88d455f39f5d005
Gitweb: https://git.kernel.org/tip/b7dc21f546d854aea75245efd88d455f39f5d005
Author: Leo Yan <[email protected]>
AuthorDate: Wed, 23 Oct 2019 16:33:24 +08:00
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Wed, 06 Nov 2019 15:43:05 -03:00

perf tests: Fix a typo

Correct typo in comment: s/suck/stuck.

Signed-off-by: Leo Yan <[email protected]>
Reported-by: Will Deacon <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Florian Fainelli <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/tests/bp_signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c
index 166f411..415903b 100644
--- a/tools/perf/tests/bp_signal.c
+++ b/tools/perf/tests/bp_signal.c
@@ -295,7 +295,7 @@ bool test__bp_signal_is_supported(void)
* breakpointed instruction.
*
* Since arm64 has the same issue with arm for the single-step
- * handling, this case also gets suck on the breakpointed
+ * handling, this case also gets stuck on the breakpointed
* instruction.
*
* Just disable the test for these architectures until these