2019-11-25 09:29:20

by Eugen Hristev

[permalink] [raw]
Subject: [PATCH] ARM: dts: at91: sama5d27_som1_ek: add i2c filters properties

From: Eugen Hristev <[email protected]>

Add properties for i2c filters for i2c0 and i2c1 on sama5d27_som1_ek.
Noise is affecting communication on i2c for example when connecting i2c
camera sensors.

Signed-off-by: Eugen Hristev <[email protected]>
---
arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
index fca5716..b6a22bb 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
@@ -123,6 +123,9 @@

flx1: flexcom@f8038000 {
atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
+ i2c-analog-filter;
+ i2c-digital-filter;
+ i2c-digital-filter-width-ns = <35>;
status = "okay";

i2c2: i2c@600 {
@@ -246,6 +249,9 @@

i2c1: i2c@fc028000 {
dmas = <0>, <0>;
+ i2c-analog-filter;
+ i2c-digital-filter;
+ i2c-digital-filter-width-ns = <35>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c1_default>;
status = "okay";
--
2.7.4


2019-12-02 17:38:46

by Alexandre Belloni

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: at91: sama5d27_som1_ek: add i2c filters properties

On 25/11/2019 09:27:41+0000, [email protected] wrote:
> From: Eugen Hristev <[email protected]>
>
> Add properties for i2c filters for i2c0 and i2c1 on sama5d27_som1_ek.
> Noise is affecting communication on i2c for example when connecting i2c
> camera sensors.
>
> Signed-off-by: Eugen Hristev <[email protected]>
> ---
> arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2019-12-05 07:47:13

by Eugen Hristev

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: at91: sama5d27_som1_ek: add i2c filters properties



On 02.12.2019 19:36, Alexandre Belloni wrote:

> On 25/11/2019 09:27:41+0000, [email protected] wrote:
>> From: Eugen Hristev <[email protected]>
>>
>> Add properties for i2c filters for i2c0 and i2c1 on sama5d27_som1_ek.
>> Noise is affecting communication on i2c for example when connecting i2c
>> camera sensors.
>>
>> Signed-off-by: Eugen Hristev <[email protected]>
>> ---
>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
> Applied, thanks.

Hi Alexandre,

The properties for i2c0 are at the wrong node. Should be at the child
node. I sent a v2 to correct it. If it's too late let me know and I can
make a fix patch instead.

Thanks and sorry,
Eugen

>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>