2019-12-03 02:33:26

by Peng Fan

Subject: [PATCH] nvmem: imx: scu: fix write SIP

From: Peng Fan <[email protected]>

SIP number 0xC200000A is for reading, 0xC200000B is for writing.
And the following two args for write are word index, data to write.

Fixes: 885ce72a09d0 ("nvmem: imx: scu: support write")
Signed-off-by: Peng Fan <[email protected]>
---
drivers/nvmem/imx-ocotp-scu.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c
index 03f1ab23ad51..455675dd8efe 100644
--- a/drivers/nvmem/imx-ocotp-scu.c
+++ b/drivers/nvmem/imx-ocotp-scu.c
@@ -15,8 +15,7 @@
#include <linux/platform_device.h>
#include <linux/slab.h>

-#define IMX_SIP_OTP 0xC200000A
-#define IMX_SIP_OTP_WRITE 0x2
+#define IMX_SIP_OTP_WRITE 0xc200000B

enum ocotp_devtype {
IMX8QXP,
@@ -212,8 +211,7 @@ static int imx_scu_ocotp_write(void *context, unsigned int offset,

mutex_lock(&scu_ocotp_mutex);

- arm_smccc_smc(IMX_SIP_OTP, IMX_SIP_OTP_WRITE, index, *buf,
- 0, 0, 0, 0, &res);
+ arm_smccc_smc(IMX_SIP_OTP_WRITE, index, *buf, 0, 0, 0, 0, 0, &res);

mutex_unlock(&scu_ocotp_mutex);

--
2.16.4

2019-12-19 10:54:21

by Srinivas Kandagatla

Subject: Re: [PATCH] nvmem: imx: scu: fix write SIP

On 03/12/2019 02:32, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> SIP number 0xC200000A is for reading, 0xC200000B is for writing.
> And the following two args for write are word index, data to write.
>
> Fixes: 885ce72a09d0 ("nvmem: imx: scu: support write")
> Signed-off-by: Peng Fan <[email protected]>

Applied Thanks,
srini