This patch disables autohibern8 feature in Cadence UFS.
The autohibern8 feature has issues due to which unexpected interrupt
trigger is happening. After the interrupt issue is sorted out autohibern8
feature will be re-enabled
Signed-off-by: sheebab <[email protected]>
---
drivers/scsi/ufs/cdns-pltfrm.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c
index b2af04c57a39..882425d1166b 100644
--- a/drivers/scsi/ufs/cdns-pltfrm.c
+++ b/drivers/scsi/ufs/cdns-pltfrm.c
@@ -98,6 +98,12 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba *hba,
* completed.
*/
ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
+
+ /*
+ * Disabling Autohibern8 feature in cadence UFS
+ * to mask unexpected interrupt trigger.
+ */
+ hba->ahit = 0;
return 0;
}
--
2.17.1
> -----Original Message-----
> From: sheebab <[email protected]>
> Sent: 03 December 2019 15:37
> To: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: [email protected]; [email protected]; sheebab
> <[email protected]>
> Subject: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS
>
> This patch disables autohibern8 feature in Cadence UFS.
> The autohibern8 feature has issues due to which unexpected interrupt
trigger is
> happening. After the interrupt issue is sorted out autohibern8 feature
will be re-
> enabled
>
> Signed-off-by: sheebab <[email protected]>
> ---
Probably we want to mark this as FIX for the older kernel version?
Reviewed-by: Alim Akhtar <[email protected]>
> drivers/scsi/ufs/cdns-pltfrm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c
b/drivers/scsi/ufs/cdns-pltfrm.c index
> b2af04c57a39..882425d1166b 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -98,6 +98,12 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba
> *hba,
> * completed.
> */
> ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
> +
> + /*
> + * Disabling Autohibern8 feature in cadence UFS
> + * to mask unexpected interrupt trigger.
> + */
> + hba->ahit = 0;
>
> return 0;
> }
> --
> 2.17.1
On 03/12/19 3:37 pm, sheebab wrote:
> This patch disables autohibern8 feature in Cadence UFS.
> The autohibern8 feature has issues due to which unexpected interrupt
> trigger is happening. After the interrupt issue is sorted out autohibern8
> feature will be re-enabled
>
> Signed-off-by: sheebab <[email protected]>
> ---
Tested-by: Vignesh Raghavendra <[email protected]>
You will have to repost patch 2/2[1] of your previous series as that
patch no longer applies cleanly anymore given that we no longer want 1/2
to be merged.
[1]
https://lore.kernel.org/linux-scsi/[email protected]/
> drivers/scsi/ufs/cdns-pltfrm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c
> index b2af04c57a39..882425d1166b 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -98,6 +98,12 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba *hba,
> * completed.
> */
> ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
> +
> + /*
> + * Disabling Autohibern8 feature in cadence UFS
> + * to mask unexpected interrupt trigger.
> + */
> + hba->ahit = 0;
>
> return 0;
> }
>
--
Regards
Vignesh
sheebab,
> This patch disables autohibern8 feature in Cadence UFS. The
> autohibern8 feature has issues due to which unexpected interrupt
> trigger is happening. After the interrupt issue is sorted out
> autohibern8 feature will be re-enabled
Applied to 5.5/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering