2019-12-13 09:49:59

by Xu Wang

Subject: [PATCH] extcon: sm5502: remove unneeded semicolon

remove unneeded semicolon
This is detected by coccinelle.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/extcon/extcon-sm5502.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
index bcf65aa..106d4da 100644
--- a/drivers/extcon/extcon-sm5502.c
+++ b/drivers/extcon/extcon-sm5502.c
@@ -249,7 +249,7 @@ static int sm5502_muic_set_path(struct sm5502_muic_info *info,
dev_err(info->dev, "Unknown DM_CON/DP_CON switch type (%d)\n",
con_sw);
return -EINVAL;
- };
+ }

switch (vbus_sw) {
case VBUSIN_SWITCH_OPEN:
@@ -268,7 +268,7 @@ static int sm5502_muic_set_path(struct sm5502_muic_info *info,
default:
dev_err(info->dev, "Unknown VBUS switch type (%d)\n", vbus_sw);
return -EINVAL;
- };
+ }

return 0;
}
@@ -357,13 +357,13 @@ static unsigned int sm5502_muic_get_cable_type(struct sm5502_muic_info *info)
"cannot identify the cable type: adc(0x%x)\n",
adc);
return -EINVAL;
- };
+ }
break;
default:
dev_err(info->dev,
"failed to identify the cable type: adc(0x%x)\n", adc);
return -EINVAL;
- };
+ }

return cable_type;
}
@@ -405,7 +405,7 @@ static int sm5502_muic_cable_handler(struct sm5502_muic_info *info,
dev_dbg(info->dev,
"cannot handle this cable_type (0x%x)\n", cable_type);
return 0;
- };
+ }

/* Change internal hardware path(DM_CON/DP_CON, VBUSIN) */
ret = sm5502_muic_set_path(info, con_sw, vbus_sw, attached);
--
2.7.4

2019-12-16 01:21:50

by Chanwoo Choi

Subject: Re: [PATCH] extcon: sm5502: remove unneeded semicolon

On 12/13/19 6:48 PM, Xu Wang wrote:
> remove unneeded semicolon
> This is detected by coccinelle.
>
> Signed-off-by: Xu Wang <[email protected]>
> ---
> drivers/extcon/extcon-sm5502.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c
> index bcf65aa..106d4da 100644
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -249,7 +249,7 @@ static int sm5502_muic_set_path(struct sm5502_muic_info *info,
> dev_err(info->dev, "Unknown DM_CON/DP_CON switch type (%d)\n",
> con_sw);
> return -EINVAL;
> - };
> + }
>
> switch (vbus_sw) {
> case VBUSIN_SWITCH_OPEN:
> @@ -268,7 +268,7 @@ static int sm5502_muic_set_path(struct sm5502_muic_info *info,
> default:
> dev_err(info->dev, "Unknown VBUS switch type (%d)\n", vbus_sw);
> return -EINVAL;
> - };
> + }
>
> return 0;
> }
> @@ -357,13 +357,13 @@ static unsigned int sm5502_muic_get_cable_type(struct sm5502_muic_info *info)
> "cannot identify the cable type: adc(0x%x)\n",
> adc);
> return -EINVAL;
> - };
> + }
> break;
> default:
> dev_err(info->dev,
> "failed to identify the cable type: adc(0x%x)\n", adc);
> return -EINVAL;
> - };
> + }
>
> return cable_type;
> }
> @@ -405,7 +405,7 @@ static int sm5502_muic_cable_handler(struct sm5502_muic_info *info,
> dev_dbg(info->dev,
> "cannot handle this cable_type (0x%x)\n", cable_type);
> return 0;
> - };
> + }
>
> /* Change internal hardware path(DM_CON/DP_CON, VBUSIN) */
> ret = sm5502_muic_set_path(info, con_sw, vbus_sw, attached);
>

Applied it. Better to use the capital letter for first char
on patch title.

--
Best Regards,
Chanwoo Choi
Samsung Electronics