2019-12-20 22:29:00

by Sowjanya Komatineni

Subject: [PATCH v5 18/19] arm64: tegra: smaug: Change clk_out_2 provider to pmc

clk_out_2 is one of the clocks from Tegra PMC block and Tegra PMC
clocks are moved from clock driver to pmc driver with pmc as clock
provider and using pmc clock ids.

This patch changes clk_out_2 provider to pmc and uses corresponding
pmc clock id for clk_out_2.

Signed-off-by: Sowjanya Komatineni <[email protected]>
---
arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 72c7a04ac1df..2faab6390552 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -1592,7 +1592,7 @@
reg = <0x1a>;
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(E, 6) IRQ_TYPE_LEVEL_LOW>;
- clocks = <&tegra_car TEGRA210_CLK_CLK_OUT_2>;
+ clocks = <&tegra_pmc TEGRA_PMC_CLK_OUT_2>;
clock-names = "mclk";

nuvoton,jkdet-enable;
--
2.7.4

2019-12-22 22:13:39

by Dmitry Osipenko

Subject: Re: [PATCH v5 18/19] arm64: tegra: smaug: Change clk_out_2 provider to pmc

21.12.2019 01:27, Sowjanya Komatineni пишет:
> clk_out_2 is one of the clocks from Tegra PMC block and Tegra PMC
> clocks are moved from clock driver to pmc driver with pmc as clock
> provider and using pmc clock ids.
>
> This patch changes clk_out_2 provider to pmc and uses corresponding
> pmc clock id for clk_out_2.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> index 72c7a04ac1df..2faab6390552 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> @@ -1592,7 +1592,7 @@
> reg = <0x1a>;
> interrupt-parent = <&gpio>;
> interrupts = <TEGRA_GPIO(E, 6) IRQ_TYPE_LEVEL_LOW>;
> - clocks = <&tegra_car TEGRA210_CLK_CLK_OUT_2>;
> + clocks = <&tegra_pmc TEGRA_PMC_CLK_OUT_2>;
> clock-names = "mclk";
>
> nuvoton,jkdet-enable;
>

Isn't "assigned-clocks" needed here?

2019-12-27 21:33:46

by Sowjanya Komatineni

Subject: Re: [PATCH v5 18/19] arm64: tegra: smaug: Change clk_out_2 provider to pmc

On 12/22/19 2:00 PM, Dmitry Osipenko wrote:
> 21.12.2019 01:27, Sowjanya Komatineni пишет:
>> clk_out_2 is one of the clocks from Tegra PMC block and Tegra PMC
>> clocks are moved from clock driver to pmc driver with pmc as clock
>> provider and using pmc clock ids.
>>
>> This patch changes clk_out_2 provider to pmc and uses corresponding
>> pmc clock id for clk_out_2.
>>
>> Signed-off-by: Sowjanya Komatineni <[email protected]>
>> ---
>> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> index 72c7a04ac1df..2faab6390552 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
>> @@ -1592,7 +1592,7 @@
>> reg = <0x1a>;
>> interrupt-parent = <&gpio>;
>> interrupts = <TEGRA_GPIO(E, 6) IRQ_TYPE_LEVEL_LOW>;
>> - clocks = <&tegra_car TEGRA210_CLK_CLK_OUT_2>;
>> + clocks = <&tegra_pmc TEGRA_PMC_CLK_OUT_2>;
>> clock-names = "mclk";
>>
>> nuvoton,jkdet-enable;
>>
> Isn't "assigned-clocks" needed here?

from existing device tree and clock driver init table clk_out_2 is from
clk_m and not using extperiph2.

So to have same clock configuration, didnt added assigned-clocks as
default clk_out_2 parent is clk_m