2019-12-23 01:56:36

by Yi Wang

Subject: [PATCH] sched: Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP_ZERO.

From: Huang Zijiang <[email protected]>

Use kmem_cache_zalloc instead of manually setting kmem_cache_alloc
with flag GFP_ZERO since kzalloc sets allocated memory
to zero.

Signed-off-by: Huang Zijiang <[email protected]>
Signed-off-by: Yi Wang <[email protected]>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index f2b111b..981ee92 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6939,7 +6939,7 @@ struct task_group *sched_create_group(struct task_group *parent)
{
struct task_group *tg;

- tg = kmem_cache_alloc(task_group_cache, GFP_KERNEL | __GFP_ZERO);
+tg = kmem_cache_zalloc(task_group_cache, GFP_KERNEL);
if (!tg)
return ERR_PTR(-ENOMEM);

--
1.9.1

2019-12-23 16:09:54

by Markus Elfring

Subject: Re: [PATCH] sched: Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP_ZERO.

…
> +++ b/kernel/sched/core.c
> @@ -6939,7 +6939,7 @@ struct task_group *sched_create_group(struct task_group *parent)
…
> - tg = kmem_cache_alloc(task_group_cache, GFP_KERNEL | __GFP_ZERO);
> +tg = kmem_cache_zalloc(task_group_cache, GFP_KERNEL);
> if (!tg)
…

Please fix the indentation.

Would you like to apply a script for the semantic patch language
like the following?

@replacement@
expression gfp, x;
@@
x =
(
- kmalloc
+ kzalloc
|
- kmem_cache_alloc
+ kmem_cache_zalloc
)
(...,
gfp
- | __GFP_ZERO
)


Regards,
Markus