2019-12-24 09:32:21

by Zheng Bin

Subject: [PATCH 0/4] tty: use true,false for bool variable

zhengbin (4):
tty: synclink_gt: use true,false for bool variable
tty/serial: kgdb_nmi: use true,false for bool variable
tty/serial: atmel: use true,false for bool variable
tty/serial: 8250_exar: use true,false for bool variable

drivers/tty/serial/8250/8250_exar.c | 6 +++---
drivers/tty/serial/atmel_serial.c | 6 +++---
drivers/tty/serial/kgdb_nmi.c | 4 ++--
drivers/tty/synclink_gt.c | 2 +-
4 files changed, 9 insertions(+), 9 deletions(-)

--
2.7.4

2019-12-24 09:33:12

by Zheng Bin

Subject: [PATCH 3/4] tty/serial: atmel: use true,false for bool variable

Fixes coccicheck warning:

drivers/tty/serial/atmel_serial.c:1062:1-23: WARNING: Assignment of 0/1 to bool variable
drivers/tty/serial/atmel_serial.c:1261:1-23: WARNING: Assignment of 0/1 to bool variable
drivers/tty/serial/atmel_serial.c:1688:3-25: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: zhengbin <[email protected]>
---
drivers/tty/serial/atmel_serial.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index fa19eb3..181da0c 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -1059,7 +1059,7 @@ static int atmel_prepare_tx_dma(struct uart_port *port)

chan_err:
dev_err(port->dev, "TX channel not available, switch to pio\n");
- atmel_port->use_dma_tx = 0;
+ atmel_port->use_dma_tx = false;
if (atmel_port->chan_tx)
atmel_release_tx_dma(port);
return -EINVAL;
@@ -1258,7 +1258,7 @@ static int atmel_prepare_rx_dma(struct uart_port *port)

chan_err:
dev_err(port->dev, "RX channel not available, switch to pio\n");
- atmel_port->use_dma_rx = 0;
+ atmel_port->use_dma_rx = false;
if (atmel_port->chan_rx)
atmel_release_rx_dma(port);
return -EINVAL;
@@ -1685,7 +1685,7 @@ static int atmel_prepare_rx_pdc(struct uart_port *port)
DMA_FROM_DEVICE);
kfree(atmel_port->pdc_rx[0].buf);
}
- atmel_port->use_pdc_rx = 0;
+ atmel_port->use_pdc_rx = false;
return -ENOMEM;
}
pdc->dma_addr = dma_map_single(port->dev,
--
2.7.4

2020-01-11 20:04:04

by Greg KH

Subject: Re: [PATCH 0/4] tty: use true,false for bool variable

On Tue, Dec 24, 2019 at 05:38:01PM +0800, zhengbin wrote:
> zhengbin (4):

I need a "real" name here, one that you use to sign documents.

Can you fix that up for all 4 of these patches and resend the series?

thanks,

greg k-h