The vdd3p0's input should be from external USB VBUS directly, NOT
PMIC's sw2, so remove the power supply assignment for vdd3p0.
Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding power supply for LDOs")
Signed-off-by: Anson Huang <[email protected]>
---
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 71ca76a..fe59dde 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -749,10 +749,6 @@
vin-supply = <&vgen5_reg>;
};
-®_vdd3p0 {
- vin-supply = <&sw2_reg>;
-};
-
®_vdd2p5 {
vin-supply = <&vgen5_reg>;
};
--
2.7.4
The vdd3p0's input should be from external USB VBUS directly, NOT
PMIC's sw2, so remove the power supply assignment for vdd3p0.
Fixes: 96a9169cf621 ("ARM: dts: imx6sll-evk: Assign corresponding power supply for vdd3p0")
Signed-off-by: Anson Huang <[email protected]>
---
arch/arm/boot/dts/imx6sll-evk.dts | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx6sll-evk.dts b/arch/arm/boot/dts/imx6sll-evk.dts
index 3e1d32f..5ace9e6 100644
--- a/arch/arm/boot/dts/imx6sll-evk.dts
+++ b/arch/arm/boot/dts/imx6sll-evk.dts
@@ -265,10 +265,6 @@
status = "okay";
};
-®_3p0 {
- vin-supply = <&sw2_reg>;
-};
-
&snvs_poweroff {
status = "okay";
};
--
2.7.4
On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> The vdd3p0's input should be from external USB VBUS directly, NOT
Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V which
is suggested by vdd3p0 name.
> PMIC's sw2, so remove the power supply assignment for vdd3p0.
>
> Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding power supply for LDOs")
Is it only a description correcting or is it fixing a real problem? I'm
trying to understand it is a 5.5-rc material or can be applied for 5.6.
Shawn
> Signed-off-by: Anson Huang <[email protected]>
> ---
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 71ca76a..fe59dde 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -749,10 +749,6 @@
> vin-supply = <&vgen5_reg>;
> };
>
> -®_vdd3p0 {
> - vin-supply = <&sw2_reg>;
> -};
> -
> ®_vdd2p5 {
> vin-supply = <&vgen5_reg>;
> };
> --
> 2.7.4
>
Hi, Shawn
> Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> power supply assignment
>
> On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > The vdd3p0's input should be from external USB VBUS directly, NOT
>
> Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V which is
> suggested by vdd3p0 name.
>
> > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> >
> > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding
> > power supply for LDOs")
>
> Is it only a description correcting or is it fixing a real problem? I'm trying to
> understand it is a 5.5-rc material or can be applied for 5.6.
>
It is fixing a real problem about USB LDO voltage, that is why we noticed this issue.
Thanks,
Anson.
On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> Hi, Shawn
>
> > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > power supply assignment
> >
> > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > The vdd3p0's input should be from external USB VBUS directly, NOT
> >
> > Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V which is
> > suggested by vdd3p0 name.
> >
> > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > >
> > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign corresponding
> > > power supply for LDOs")
> >
> > Is it only a description correcting or is it fixing a real problem? I'm trying to
> > understand it is a 5.5-rc material or can be applied for 5.6.
> >
>
> It is fixing a real problem about USB LDO voltage, that is why we noticed this issue.
Okay, please describe the problem a little bit in the commit log. Also
squash the series into one patch, which is easier to be merged into -rc
as a fix.
My question above that USB VUBS is 5V which doesn't match 3.0V
suggested by vdd3p0 name remains unaddressed though.
Shawn
Hi, Shawn
> Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> power supply assignment
>
> On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> > Hi, Shawn
> >
> > > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > > power supply assignment
> > >
> > > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > > The vdd3p0's input should be from external USB VBUS directly, NOT
> > >
> > > Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V
> > > which is suggested by vdd3p0 name.
> > >
> > > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > > >
> > > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
> > > > corresponding power supply for LDOs")
> > >
> > > Is it only a description correcting or is it fixing a real problem?
> > > I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
> > >
> >
> > It is fixing a real problem about USB LDO voltage, that is why we noticed
> this issue.
>
> Okay, please describe the problem a little bit in the commit log. Also squash
> the series into one patch, which is easier to be merged into -rc as a fix.
OK, will send a new patch with squashing them together, but will NOT have the fix tag,
is it OK? As the fix tag are different for each patch.
>
> My question above that USB VUBS is 5V which doesn't match 3.0V suggested
> by vdd3p0 name remains unaddressed though.
The vdd3p0 is a LDO, the input is the USB VBUS 5V, output can be programmed to
3.2V, I think the name is from the target output voltage.
Anson
> Subject: RE: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> power supply assignment
>
> Hi, Shawn
>
> > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > power supply assignment
> >
> > On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> > > Hi, Shawn
> > >
> > > > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove
> > > > incorrect power supply assignment
> > > >
> > > > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > > > The vdd3p0's input should be from external USB VBUS directly,
> > > > > NOT
> > > >
> > > > Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V
> > > > which is suggested by vdd3p0 name.
> > > >
> > > > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > > > >
> > > > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
> > > > > corresponding power supply for LDOs")
> > > >
> > > > Is it only a description correcting or is it fixing a real problem?
> > > > I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
> > > >
> > >
> > > It is fixing a real problem about USB LDO voltage, that is why we
> > > noticed
> > this issue.
> >
> > Okay, please describe the problem a little bit in the commit log.
> > Also squash the series into one patch, which is easier to be merged into -rc
> as a fix.
>
> OK, will send a new patch with squashing them together, but will NOT have
> the fix tag, is it OK? As the fix tag are different for each patch.
Never mind, I think I can put all 5 Fixes tag together in new patch.
Thanks,
Anson
On Thu, Jan 09, 2020 at 09:25:35AM +0000, Anson Huang wrote:
> Hi, Shawn
>
> > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > power supply assignment
> >
> > On Thu, Jan 09, 2020 at 08:25:03AM +0000, Anson Huang wrote:
> > > Hi, Shawn
> > >
> > > > Subject: Re: [PATCH 1/5] ARM: dts: imx6qdl-sabresd: Remove incorrect
> > > > power supply assignment
> > > >
> > > > On Mon, Dec 30, 2019 at 09:41:07AM +0800, Anson Huang wrote:
> > > > > The vdd3p0's input should be from external USB VBUS directly, NOT
> > > >
> > > > Shouldn't USB VBUS usually be 5V? It doesn't seem to match 3.0V
> > > > which is suggested by vdd3p0 name.
> > > >
> > > > > PMIC's sw2, so remove the power supply assignment for vdd3p0.
> > > > >
> > > > > Fixes: 93385546ba36 ("ARM: dts: imx6qdl-sabresd: Assign
> > > > > corresponding power supply for LDOs")
> > > >
> > > > Is it only a description correcting or is it fixing a real problem?
> > > > I'm trying to understand it is a 5.5-rc material or can be applied for 5.6.
> > > >
> > >
> > > It is fixing a real problem about USB LDO voltage, that is why we noticed
> > this issue.
> >
> > Okay, please describe the problem a little bit in the commit log. Also squash
> > the series into one patch, which is easier to be merged into -rc as a fix.
>
> OK, will send a new patch with squashing them together, but will NOT have the fix tag,
> is it OK? As the fix tag are different for each patch.
Good point. I just applied series (as separate patch) to make the
stable kernel back port easier. Patch #5 is fixing a commit that hasn't
landed on mainline, so I drop the fix tag, as the commit ID is not
stable.
Shawn