2020-01-03 09:21:51

by Xu Wang

Subject: [PATCH] net: Remove redundant BUG_ON() check in phonet_pernet

Passing NULL to phonet_pernet causes a crash via BUG_ON.
Dereferencing net in net_generic() also has the same effect.
This patch removes the redundant BUG_ON check on the same parameter.

Signed-off-by: Xu Wang <[email protected]>
---
net/phonet/pn_dev.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/phonet/pn_dev.c b/net/phonet/pn_dev.c
index 49bd76a..ac0fae0 100644
--- a/net/phonet/pn_dev.c
+++ b/net/phonet/pn_dev.c
@@ -35,8 +35,6 @@ static unsigned int phonet_net_id __read_mostly;

static struct phonet_net *phonet_pernet(struct net *net)
{
- BUG_ON(!net);
-
return net_generic(net, phonet_net_id);
}

--
2.7.4

2020-01-03 20:27:32

by David Miller

Subject: Re: [PATCH] net: Remove redundant BUG_ON() check in phonet_pernet

From: Xu Wang <[email protected]>
Date: Fri, 3 Jan 2020 09:20:40 +0000

> Passing NULL to phonet_pernet causes a crash via BUG_ON.
> Dereferencing net in net_generic() also has the same effect.
> This patch removes the redundant BUG_ON check on the same parameter.
>
> Signed-off-by: Xu Wang <[email protected]>

Applied.