2020-01-14 13:39:06

by Zhangshaokun

Subject: [PATCH -next] gpio: Remove the unused flags

drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
unsigned long flags;
^
Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
Cc: Jia-Ju Bai <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Signed-off-by: Shaokun Zhang <[email protected]>
---
drivers/gpio/gpio-grgpio.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
index 1922adf96fc9..f954359c9544 100644
--- a/drivers/gpio/gpio-grgpio.c
+++ b/drivers/gpio/gpio-grgpio.c
@@ -435,7 +435,6 @@ static int grgpio_probe(struct platform_device *ofdev)
static int grgpio_remove(struct platform_device *ofdev)
{
struct grgpio_priv *priv = platform_get_drvdata(ofdev);
- unsigned long flags;
int i;
int ret = 0;

--
2.7.4

2020-01-14 14:12:15

by Bartosz Golaszewski

Subject: Re: [PATCH -next] gpio: Remove the unused flags

wt., 14 sty 2020 o 14:38 Shaokun Zhang <[email protected]> napisał(a):
>
> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
> unsigned long flags;
> ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Signed-off-by: Shaokun Zhang <[email protected]>

Reviewed-by: Bartosz Golaszewski <[email protected]>

2020-01-15 01:37:49

by Jia-Ju Bai

Subject: Re: [PATCH -next] gpio: Remove the unused flags

On 2020/1/14 21:37, Shaokun Zhang wrote:
> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
> unsigned long flags;
> ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Signed-off-by: Shaokun Zhang <[email protected]>
> ---
> drivers/gpio/gpio-grgpio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
> index 1922adf96fc9..f954359c9544 100644
> --- a/drivers/gpio/gpio-grgpio.c
> +++ b/drivers/gpio/gpio-grgpio.c
> @@ -435,7 +435,6 @@ static int grgpio_probe(struct platform_device *ofdev)
> static int grgpio_remove(struct platform_device *ofdev)
> {
> struct grgpio_priv *priv = platform_get_drvdata(ofdev);
> - unsigned long flags;
> int i;
> int ret = 0;
>

Reviewed-by: Jia-Ju Bai <[email protected]>

2020-01-15 10:26:39

by Linus Walleij

Subject: Re: [PATCH -next] gpio: Remove the unused flags

On Tue, Jan 14, 2020 at 2:38 PM Shaokun Zhang
<[email protected]> wrote:

> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
> unsigned long flags;
> ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Signed-off-by: Shaokun Zhang <[email protected]>

Patch applied with the ACKs!

Thanks!
Linus Walleij