2020-01-16 06:42:35

by Peng Fan

Subject: [PATCH] dt-bindings: soc: imx: add binding doc for aips bus

From: Peng Fan <[email protected]>

Add binding doc for fsl,aips-bus

Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/soc/imx/fsl,aips-bus.yaml | 38 ++++++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml

diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml
new file mode 100644
index 000000000000..73ce1b7fc306
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/imx/fsl,aips-bus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: i.MX AHB to IP Bridge
+
+maintainers:
+ - Peng Fan <[email protected]>
+
+description: |
+ This particular peripheral is designed as the bridge between
+ AHB bus and peripherals with the lower bandwidth IP Slave (IPS)
+ buses.
+
+properties:
+ compatible:
+ oneOf:
+ - const: fsl,aips-bus
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ bus@30000000 {
+ compatible = "fsl,aips-bus", "simple-bus";
+ reg = <0x30000000 0x400000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+ };
+...
--
2.16.4

2020-01-21 23:22:37

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: soc: imx: add binding doc for aips bus

On Thu, Jan 16, 2020 at 06:12:12AM +0000, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> Add binding doc for fsl,aips-bus
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> .../devicetree/bindings/soc/imx/fsl,aips-bus.yaml | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml
> new file mode 100644
> index 000000000000..73ce1b7fc306
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,aips-bus.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/imx/fsl,aips-bus.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX AHB to IP Bridge
> +
> +maintainers:
> + - Peng Fan <[email protected]>
> +
> +description: |
> + This particular peripheral is designed as the bridge between
> + AHB bus and peripherals with the lower bandwidth IP Slave (IPS)
> + buses.
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: fsl,aips-bus
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + bus@30000000 {
> + compatible = "fsl,aips-bus", "simple-bus";

'make dt_binding_check' should be failing for you because this doesn't
match the schema. You need to add 'simple-bus'. However doing so will
make this schema match on any node with 'simple-bus'. See 'select' in
various arm,primecell schemas for how to avoid this problem.

Rob

> + reg = <0x30000000 0x400000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + };
> +...
> --
> 2.16.4
>