2020-01-28 05:37:47

by chenqiwu

Subject: [PATCH] dma: ti: dma-crossbar: convert to devm_platform_ioremap_resource()

From: chenqiwu <[email protected]>

Use a new API devm_platform_ioremap_resource() to simplify code.

Signed-off-by: chenqiwu <[email protected]>
---
drivers/dma/ti/dma-crossbar.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index f255056..4ba8fa5 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -133,7 +133,6 @@ static int ti_am335x_xbar_probe(struct platform_device *pdev)
const struct of_device_id *match;
struct device_node *dma_node;
struct ti_am335x_xbar_data *xbar;
- struct resource *res;
void __iomem *iomem;
int i, ret;

@@ -173,8 +172,7 @@ static int ti_am335x_xbar_probe(struct platform_device *pdev)
xbar->xbar_events = TI_AM335X_XBAR_LINES;
}

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- iomem = devm_ioremap_resource(&pdev->dev, res);
+ iomem = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(iomem))
return PTR_ERR(iomem);

@@ -323,7 +321,6 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
struct device_node *dma_node;
struct ti_dra7_xbar_data *xbar;
struct property *prop;
- struct resource *res;
u32 safe_val;
int sz;
void __iomem *iomem;
@@ -403,8 +400,7 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
kfree(rsv_events);
}

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- iomem = devm_ioremap_resource(&pdev->dev, res);
+ iomem = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(iomem))
return PTR_ERR(iomem);

--
1.9.1

2020-01-28 07:54:40

by Peter Ujfalusi

Subject: Re: [PATCH] dma: ti: dma-crossbar: convert to devm_platform_ioremap_resource()

On 28/01/2020 7.35, [email protected] wrote:
> From: chenqiwu <[email protected]>
>
> Use a new API devm_platform_ioremap_resource() to simplify code.

Acked-by: Peter Ujfalusi <[email protected]>

> Signed-off-by: chenqiwu <[email protected]>
> ---
> drivers/dma/ti/dma-crossbar.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index f255056..4ba8fa5 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -133,7 +133,6 @@ static int ti_am335x_xbar_probe(struct platform_device *pdev)
> const struct of_device_id *match;
> struct device_node *dma_node;
> struct ti_am335x_xbar_data *xbar;
> - struct resource *res;
> void __iomem *iomem;
> int i, ret;
>
> @@ -173,8 +172,7 @@ static int ti_am335x_xbar_probe(struct platform_device *pdev)
> xbar->xbar_events = TI_AM335X_XBAR_LINES;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - iomem = devm_ioremap_resource(&pdev->dev, res);
> + iomem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(iomem))
> return PTR_ERR(iomem);
>
> @@ -323,7 +321,6 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
> struct device_node *dma_node;
> struct ti_dra7_xbar_data *xbar;
> struct property *prop;
> - struct resource *res;
> u32 safe_val;
> int sz;
> void __iomem *iomem;
> @@ -403,8 +400,7 @@ static int ti_dra7_xbar_probe(struct platform_device *pdev)
> kfree(rsv_events);
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - iomem = devm_ioremap_resource(&pdev->dev, res);
> + iomem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(iomem))
> return PTR_ERR(iomem);
>
>

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2020-02-13 15:19:41

by Vinod Koul

Subject: Re: [PATCH] dma: ti: dma-crossbar: convert to devm_platform_ioremap_resource()

On 28-01-20, 13:35, [email protected] wrote:
> From: chenqiwu <[email protected]>
>
> Use a new API devm_platform_ioremap_resource() to simplify code.

Subsystem name is 'dmaengine' pls use that tag instead.
Applied after fixing the tag, thanks

--
~Vinod