2020-02-07 05:02:54

by Yoshio Furuyama

Subject: [PATCH v3] mtd: spinand: toshiba: Add comment about Kioxia ID

Add a comment above NAND_MFR_TOSHIBA and SPINAND_MFR_TOSHIBA definitions
that Toshiba and Kioxia ID are the same.
Since its independence from Toshiba Group, Toshiba memory Co has become
Kioxia Co.

Signed-off-by: Yoshio Furuyama <[email protected]>
---
drivers/mtd/nand/raw/internals.h | 1 +
drivers/mtd/nand/spi/toshiba.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h
index cba6fe7..9d0caad 100644
--- a/drivers/mtd/nand/raw/internals.h
+++ b/drivers/mtd/nand/raw/internals.h
@@ -30,6 +30,7 @@
#define NAND_MFR_SAMSUNG 0xec
#define NAND_MFR_SANDISK 0x45
#define NAND_MFR_STMICRO 0x20
+/* Kioxia is new name of Toshiba memory. */
#define NAND_MFR_TOSHIBA 0x98
#define NAND_MFR_WINBOND 0xef

diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c
index 0db5ee4..833e8f6 100644
--- a/drivers/mtd/nand/spi/toshiba.c
+++ b/drivers/mtd/nand/spi/toshiba.c
@@ -10,6 +10,7 @@
#include <linux/kernel.h>
#include <linux/mtd/spinand.h>

+/* Kioxia is new name of Toshiba memory. */
#define SPINAND_MFR_TOSHIBA 0x98
#define TOSH_STATUS_ECC_HAS_BITFLIPS_T (3 << 4)

--
1.9.1

2020-02-07 08:34:06

by Miquel Raynal

Subject: Re: [PATCH v3] mtd: spinand: toshiba: Add comment about Kioxia ID

Hi Yoshio,

Yoshio Furuyama <[email protected]> wrote on Fri, 7 Feb
2020 13:59:21 +0900:

> Add a comment above NAND_MFR_TOSHIBA and SPINAND_MFR_TOSHIBA definitions
> that Toshiba and Kioxia ID are the same.
> Since its independence from Toshiba Group, Toshiba memory Co has become
> Kioxia Co.
>
> Signed-off-by: Yoshio Furuyama <[email protected]>

Just as an FYI for your next submission, below the three dashes you
should add a changelog, a small paragraph describing what changed
between the versions.

No need to resend just for this, I have it in mind.

I'm fine with the patch and will apply it soon.

> ---
> drivers/mtd/nand/raw/internals.h | 1 +
> drivers/mtd/nand/spi/toshiba.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/internals.h b/drivers/mtd/nand/raw/internals.h
> index cba6fe7..9d0caad 100644
> --- a/drivers/mtd/nand/raw/internals.h
> +++ b/drivers/mtd/nand/raw/internals.h
> @@ -30,6 +30,7 @@
> #define NAND_MFR_SAMSUNG 0xec
> #define NAND_MFR_SANDISK 0x45
> #define NAND_MFR_STMICRO 0x20
> +/* Kioxia is new name of Toshiba memory. */
> #define NAND_MFR_TOSHIBA 0x98
> #define NAND_MFR_WINBOND 0xef
>
> diff --git a/drivers/mtd/nand/spi/toshiba.c b/drivers/mtd/nand/spi/toshiba.c
> index 0db5ee4..833e8f6 100644
> --- a/drivers/mtd/nand/spi/toshiba.c
> +++ b/drivers/mtd/nand/spi/toshiba.c
> @@ -10,6 +10,7 @@
> #include <linux/kernel.h>
> #include <linux/mtd/spinand.h>
>
> +/* Kioxia is new name of Toshiba memory. */
> #define SPINAND_MFR_TOSHIBA 0x98
> #define TOSH_STATUS_ECC_HAS_BITFLIPS_T (3 << 4)
>

Thanks,
Miquèl

2020-03-10 18:34:21

by Miquel Raynal

Subject: Re: [PATCH v3] mtd: spinand: toshiba: Add comment about Kioxia ID

On Fri, 2020-02-07 at 04:59:21 UTC, Yoshio Furuyama wrote:
> Add a comment above NAND_MFR_TOSHIBA and SPINAND_MFR_TOSHIBA definitions
> that Toshiba and Kioxia ID are the same.
> Since its independence from Toshiba Group, Toshiba memory Co has become
> Kioxia Co.
>
> Signed-off-by: Yoshio Furuyama <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel