2020-02-12 11:22:54

by Sandeep Maheswaram

Subject: [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: Add support for SC7180

Add compatible for SC7180 in qmp phy bindings.

Signed-off-by: Sandeep Maheswaram <[email protected]>
---
Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index b39a594..8c153e3 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -23,6 +23,7 @@ properties:
- qcom,msm8998-qmp-usb3-phy
- qcom,msm8998-qmp-ufs-phy
- qcom,msm8998-qmp-pcie-phy
+ - qcom,sc7180-qmp-usb3-phy
- qcom,sdm845-qmp-usb3-phy
- qcom,sdm845-qmp-usb3-uni-phy
- qcom,sdm845-qmp-ufs-phy
@@ -105,9 +106,10 @@ allOf:
properties:
compatible:
contains:
- enum:
- - qcom,sdm845-qmp-usb3-phy
- - qcom,sdm845-qmp-usb3-uni-phy
+ enum:
+ - qcom,sc7180-qmp-usb3-phy
+ - qcom,sdm845-qmp-usb3-phy
+ - qcom,sdm845-qmp-usb3-uni-phy
then:
properties:
clocks:
@@ -238,7 +240,9 @@ allOf:
properties:
compatible:
contains:
- const: qcom,sdm845-qmp-usb3-phy
+ enum:
+ - qcom,sc7180-qmp-usb3-phy
+ - qcom,sdm845-qmp-usb3-phy
then:
required:
- reg-names
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2020-02-12 20:30:29

by Matthias Kaehlcke

Subject: Re: [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: Add support for SC7180

On Wed, Feb 12, 2020 at 04:51:26PM +0530, Sandeep Maheswaram wrote:
> Add compatible for SC7180 in qmp phy bindings.

nit: QMP PHY

> Signed-off-by: Sandeep Maheswaram <[email protected]>
> ---
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index b39a594..8c153e3 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -23,6 +23,7 @@ properties:
> - qcom,msm8998-qmp-usb3-phy
> - qcom,msm8998-qmp-ufs-phy
> - qcom,msm8998-qmp-pcie-phy
> + - qcom,sc7180-qmp-usb3-phy
> - qcom,sdm845-qmp-usb3-phy
> - qcom,sdm845-qmp-usb3-uni-phy
> - qcom,sdm845-qmp-ufs-phy
> @@ -105,9 +106,10 @@ allOf:
> properties:
> compatible:
> contains:
> - enum:
> - - qcom,sdm845-qmp-usb3-phy
> - - qcom,sdm845-qmp-usb3-uni-phy
> + enum:
> + - qcom,sc7180-qmp-usb3-phy
> + - qcom,sdm845-qmp-usb3-phy
> + - qcom,sdm845-qmp-usb3-uni-phy

There is some extra churn from fixing the indentation, but that's the
fault of the parent patch and will go away when $parent is fixed.

> then:
> properties:
> clocks:
> @@ -238,7 +240,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: qcom,sdm845-qmp-usb3-phy
> + enum:
> + - qcom,sc7180-qmp-usb3-phy
> + - qcom,sdm845-qmp-usb3-phy
> then:
> required:
> - reg-names

Reviewed-by: Matthias Kaehlcke <[email protected]>

2020-02-18 23:05:57

by Rob Herring (Arm)

Subject: Re: [PATCH v3 2/4] dt-bindings: phy: qcom,qmp: Add support for SC7180

On Wed, 12 Feb 2020 16:51:26 +0530, Sandeep Maheswaram wrote:
> Add compatible for SC7180 in qmp phy bindings.
>
> Signed-off-by: Sandeep Maheswaram <[email protected]>
> ---
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>