2020-02-12 12:05:23

by Anson Huang

[permalink] [raw]
Subject: [PATCH 3/5] clk: imx8mm: Add missing of_node_put()

After finishing using device node got from of_find_compatible_node(),
of_node_put() needs to be called.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/clk/imx/clk-imx8mm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
index 3d19e87..e09c13a 100644
--- a/drivers/clk/imx/clk-imx8mm.c
+++ b/drivers/clk/imx/clk-imx8mm.c
@@ -322,6 +322,7 @@ static int imx8mm_clocks_probe(struct platform_device *pdev)

np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop");
base = of_iomap(np, 0);
+ of_node_put(np);
if (WARN_ON(!base))
return -ENOMEM;

--
2.7.4


2020-02-12 20:57:24

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH 3/5] clk: imx8mm: Add missing of_node_put()

Quoting Anson Huang (2020-02-12 03:57:35)
> After finishing using device node got from of_find_compatible_node(),
> of_node_put() needs to be called.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>