2020-02-12 09:55:37

by Bibby Hsieh

Subject: [PATCH 2/2] drm/mediatek: move gce event property to mutex device node

According mtk hardware design, stream_done0 and stream_done1 are
generated by mutex, so we move gce event property to mutex device mode.

Signed-off-by: Bibby Hsieh <[email protected]>
---
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
index 3c53ea22208c..8a31e5b983db 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
@@ -819,7 +819,7 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev,
drm_crtc_index(&mtk_crtc->base));
mtk_crtc->cmdq_client = NULL;
}
- ret = of_property_read_u32_index(dev->of_node, "mediatek,gce-events",
+ ret = of_property_read_u32_index(priv->mutex_node, "mediatek,gce-events",
drm_crtc_index(&mtk_crtc->base),
&mtk_crtc->cmdq_event);
if (ret)
--
2.18.0

2020-02-12 10:45:10

by CK Hu (胡俊光)

Subject: Re: [PATCH 2/2] drm/mediatek: move gce event property to mutex device node

Hi, Bibby:

On Wed, 2020-02-12 at 17:55 +0800, Bibby Hsieh wrote:
> According mtk hardware design, stream_done0 and stream_done1 are
> generated by mutex, so we move gce event property to mutex device mode.
>

Reviewed-by: CK Hu <[email protected]>

> Signed-off-by: Bibby Hsieh <[email protected]>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index 3c53ea22208c..8a31e5b983db 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -819,7 +819,7 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev,
> drm_crtc_index(&mtk_crtc->base));
> mtk_crtc->cmdq_client = NULL;
> }
> - ret = of_property_read_u32_index(dev->of_node, "mediatek,gce-events",
> + ret = of_property_read_u32_index(priv->mutex_node, "mediatek,gce-events",
> drm_crtc_index(&mtk_crtc->base),
> &mtk_crtc->cmdq_event);
> if (ret)

2020-02-18 08:01:13

by CK Hu (胡俊光)

Subject: Re: [PATCH 2/2] drm/mediatek: move gce event property to mutex device node

Hi, Bibby:

On Wed, 2020-02-12 at 18:44 +0800, CK Hu wrote:
> Hi, Bibby:
>
> On Wed, 2020-02-12 at 17:55 +0800, Bibby Hsieh wrote:
> > According mtk hardware design, stream_done0 and stream_done1 are
> > generated by mutex, so we move gce event property to mutex device mode.
> >
>
> Reviewed-by: CK Hu <[email protected]>
>

Applied to mediatek-drm-fixes-5.6 [1], thanks.

[1]
https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-fixes-5.6

Regards,
CK

> > Signed-off-by: Bibby Hsieh <[email protected]>
> > ---
> > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> > index 3c53ea22208c..8a31e5b983db 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> > @@ -819,7 +819,7 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev,
> > drm_crtc_index(&mtk_crtc->base));
> > mtk_crtc->cmdq_client = NULL;
> > }
> > - ret = of_property_read_u32_index(dev->of_node, "mediatek,gce-events",
> > + ret = of_property_read_u32_index(priv->mutex_node, "mediatek,gce-events",
> > drm_crtc_index(&mtk_crtc->base),
> > &mtk_crtc->cmdq_event);
> > if (ret)
>