This serie remove a useless (char*) cast for some xxx_driver.name.
pci_driver, device_driver, usb_composite_driver structures have a "name"
member which is const char * and all the driver patched assigned to it a
const char[] name, so the cast was bad and unnecessary.
Corentin Labbe (20):
usb: gadget: legacy: gmidi: remove useless cast for driver.name
usb: gadget: legacy: inode: remove useless cast for driver.name
usb: gadget: udc: amd5536udc_pci: remove useless cast for driver.name
usb: gadget: at91_udc: remove useless cast for driver.name
usb: gadget: dummy_hcd: remove useless cast for driver.name
usb: gadget: fotg210-udc: remove useless cast for driver.name
usb: gadget: fusb300_udc: remove useless cast for driver.name
usb: gadget: goku_udc: remove useless cast for driver.name
usb: gadget: lpc32xx_udc: remove useless cast for driver.name
usb: gadget: m66592-udc: remove useless cast for driver.name
usb: gadget: net2280: remove useless cast for driver.name
usb: gadget: omap_udc: remove useless cast for driver.name
usb: gadget: r8a66597-udc: remove useless cast for driver.name
usb: gadget: renesas_usb3: remove useless cast for driver.name
usb: host: ehci-pci: remove useless cast for driver.name
usb: host: ohci-pci: remove useless cast for driver.name
usb: host: sl811-hcd: remove useless cast for driver.name
usb: host: uhci-pci: remove useless cast for driver.name
usb: host: xhci-pci: remove useless cast for driver.name
usb: musb: core: remove useless cast for driver.name
drivers/usb/gadget/legacy/gmidi.c | 2 +-
drivers/usb/gadget/legacy/inode.c | 2 +-
drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
drivers/usb/gadget/udc/at91_udc.c | 2 +-
drivers/usb/gadget/udc/dummy_hcd.c | 4 ++--
drivers/usb/gadget/udc/fotg210-udc.c | 2 +-
drivers/usb/gadget/udc/fusb300_udc.c | 2 +-
drivers/usb/gadget/udc/goku_udc.c | 2 +-
drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
drivers/usb/gadget/udc/m66592-udc.c | 2 +-
drivers/usb/gadget/udc/net2280.c | 2 +-
drivers/usb/gadget/udc/omap_udc.c | 2 +-
drivers/usb/gadget/udc/r8a66597-udc.c | 2 +-
drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
drivers/usb/host/ehci-pci.c | 2 +-
drivers/usb/host/ohci-pci.c | 2 +-
drivers/usb/host/sl811-hcd.c | 2 +-
drivers/usb/host/uhci-pci.c | 2 +-
drivers/usb/host/xhci-pci.c | 2 +-
drivers/usb/musb/musb_core.c | 2 +-
20 files changed, 21 insertions(+), 21 deletions(-)
--
2.24.1
device_driver name is const char pointer, so it not useful to cast
hcd_name (which is already const char).
Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/host/sl811-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c
index 72a34a1eb618..adaf4063690a 100644
--- a/drivers/usb/host/sl811-hcd.c
+++ b/drivers/usb/host/sl811-hcd.c
@@ -1792,7 +1792,7 @@ struct platform_driver sl811h_driver = {
.suspend = sl811h_suspend,
.resume = sl811h_resume,
.driver = {
- .name = (char *) hcd_name,
+ .name = hcd_name,
},
};
EXPORT_SYMBOL(sl811h_driver);
--
2.24.1
pci_driver name is const char pointer, so it not useful to cast
hcd_name (which is already const char).
Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/host/ehci-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index b0882c13a1d1..1a48ab1bd3b2 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -384,7 +384,7 @@ MODULE_DEVICE_TABLE(pci, pci_ids);
/* pci driver glue; this is a "new style" PCI driver module */
static struct pci_driver ehci_pci_driver = {
- .name = (char *) hcd_name,
+ .name = hcd_name,
.id_table = pci_ids,
.probe = ehci_pci_probe,
--
2.24.1
pci_driver name is const char pointer, so it not useful to cast
name (which is already const char).
Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/amd5536udc_pci.c b/drivers/usb/gadget/udc/amd5536udc_pci.c
index bfd1c9e80a1f..80685e4306f3 100644
--- a/drivers/usb/gadget/udc/amd5536udc_pci.c
+++ b/drivers/usb/gadget/udc/amd5536udc_pci.c
@@ -202,7 +202,7 @@ MODULE_DEVICE_TABLE(pci, pci_id);
/* PCI functions */
static struct pci_driver udc_pci_driver = {
- .name = (char *) name,
+ .name = name,
.id_table = pci_id,
.probe = udc_pci_probe,
.remove = udc_pci_remove,
--
2.24.1
device_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).
Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/gadget/udc/omap_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c
index bd12417996db..bf87c6c0d7f6 100644
--- a/drivers/usb/gadget/udc/omap_udc.c
+++ b/drivers/usb/gadget/udc/omap_udc.c
@@ -3001,7 +3001,7 @@ static struct platform_driver udc_driver = {
.suspend = omap_udc_suspend,
.resume = omap_udc_resume,
.driver = {
- .name = (char *) driver_name,
+ .name = driver_name,
},
};
--
2.24.1
device_driver name is const char pointer, so it not useful to cast
udc_name (which is already const char).
Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/gadget/udc/fusb300_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c
index 00e3f66836a9..9af8b415f303 100644
--- a/drivers/usb/gadget/udc/fusb300_udc.c
+++ b/drivers/usb/gadget/udc/fusb300_udc.c
@@ -1507,7 +1507,7 @@ static int fusb300_probe(struct platform_device *pdev)
static struct platform_driver fusb300_driver = {
.remove = fusb300_remove,
.driver = {
- .name = (char *) udc_name,
+ .name = udc_name,
},
};
--
2.24.1
device_driver name is const char pointer, so it not useful to cast
driver_name (which is already const char).
Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/gadget/udc/dummy_hcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 4c9d1e49d5ed..6e3e3ebf715f 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -1134,7 +1134,7 @@ static struct platform_driver dummy_udc_driver = {
.suspend = dummy_udc_suspend,
.resume = dummy_udc_resume,
.driver = {
- .name = (char *) gadget_name,
+ .name = gadget_name,
},
};
@@ -2720,7 +2720,7 @@ static struct platform_driver dummy_hcd_driver = {
.suspend = dummy_hcd_suspend,
.resume = dummy_hcd_resume,
.driver = {
- .name = (char *) driver_name,
+ .name = driver_name,
},
};
--
2.24.1
On Tue, Feb 18, 2020 at 07:32:43PM +0000, Corentin Labbe wrote:
> This serie remove a useless (char*) cast for some xxx_driver.name.
> pci_driver, device_driver, usb_composite_driver structures have a "name"
> member which is const char * and all the driver patched assigned to it a
> const char[] name, so the cast was bad and unnecessary.
>
> Corentin Labbe (20):
> usb: gadget: legacy: gmidi: remove useless cast for driver.name
> usb: gadget: legacy: inode: remove useless cast for driver.name
> usb: gadget: udc: amd5536udc_pci: remove useless cast for driver.name
> usb: gadget: at91_udc: remove useless cast for driver.name
> usb: gadget: dummy_hcd: remove useless cast for driver.name
> usb: gadget: fotg210-udc: remove useless cast for driver.name
> usb: gadget: fusb300_udc: remove useless cast for driver.name
> usb: gadget: goku_udc: remove useless cast for driver.name
> usb: gadget: lpc32xx_udc: remove useless cast for driver.name
> usb: gadget: m66592-udc: remove useless cast for driver.name
> usb: gadget: net2280: remove useless cast for driver.name
> usb: gadget: omap_udc: remove useless cast for driver.name
> usb: gadget: r8a66597-udc: remove useless cast for driver.name
> usb: gadget: renesas_usb3: remove useless cast for driver.name
> usb: host: ehci-pci: remove useless cast for driver.name
> usb: host: ohci-pci: remove useless cast for driver.name
> usb: host: sl811-hcd: remove useless cast for driver.name
> usb: host: uhci-pci: remove useless cast for driver.name
> usb: host: xhci-pci: remove useless cast for driver.name
> usb: musb: core: remove useless cast for driver.name
Please do trivial conversions like this one in one patch per subsystem
(e.g. all of USB) instead of 20 one-line patches.
You may also want to refer to commit 8d790d740858 ("[PATCH] make
driver's name be const char *") for the historical background for this
in the commit message.
> drivers/usb/gadget/legacy/gmidi.c | 2 +-
> drivers/usb/gadget/legacy/inode.c | 2 +-
> drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
> drivers/usb/gadget/udc/at91_udc.c | 2 +-
> drivers/usb/gadget/udc/dummy_hcd.c | 4 ++--
> drivers/usb/gadget/udc/fotg210-udc.c | 2 +-
> drivers/usb/gadget/udc/fusb300_udc.c | 2 +-
> drivers/usb/gadget/udc/goku_udc.c | 2 +-
> drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +-
> drivers/usb/gadget/udc/m66592-udc.c | 2 +-
> drivers/usb/gadget/udc/net2280.c | 2 +-
> drivers/usb/gadget/udc/omap_udc.c | 2 +-
> drivers/usb/gadget/udc/r8a66597-udc.c | 2 +-
> drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
> drivers/usb/host/ehci-pci.c | 2 +-
> drivers/usb/host/ohci-pci.c | 2 +-
> drivers/usb/host/sl811-hcd.c | 2 +-
> drivers/usb/host/uhci-pci.c | 2 +-
> drivers/usb/host/xhci-pci.c | 2 +-
> drivers/usb/musb/musb_core.c | 2 +-
> 20 files changed, 21 insertions(+), 21 deletions(-)
Thanks,
Johan