2020-02-19 03:50:17

by Yash Shah

Subject: [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file

Add the ability to reboot the HiFive Unleashed board via GPIO.

Signed-off-by: Yash Shah <[email protected]>
---
arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 609198c..4a2729f 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -2,6 +2,7 @@
/* Copyright (c) 2018-2019 SiFive, Inc */

#include "fu540-c000.dtsi"
+#include <dt-bindings/gpio/gpio.h>

/* Clock frequency (in Hz) of the PCB crystal for rtcclk */
#define RTCCLK_FREQ 1000000
@@ -41,6 +42,10 @@
clock-frequency = <RTCCLK_FREQ>;
clock-output-names = "rtcclk";
};
+ gpio-restart {
+ compatible = "gpio-restart";
+ gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
+ };
};

&uart0 {
--
2.7.4

2020-03-04 03:46:25

by Anup Patel

Subject: Re: [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file

On Wed, Feb 19, 2020 at 9:19 AM Yash Shah <[email protected]> wrote:
>
> Add the ability to reboot the HiFive Unleashed board via GPIO.
>
> Signed-off-by: Yash Shah <[email protected]>

LGTM.

Reviewed-by: Anup Patel <[email protected]>

Regards,
Anup

> ---
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 609198c..4a2729f 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -2,6 +2,7 @@
> /* Copyright (c) 2018-2019 SiFive, Inc */
>
> #include "fu540-c000.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> /* Clock frequency (in Hz) of the PCB crystal for rtcclk */
> #define RTCCLK_FREQ 1000000
> @@ -41,6 +42,10 @@
> clock-frequency = <RTCCLK_FREQ>;
> clock-output-names = "rtcclk";
> };
> + gpio-restart {
> + compatible = "gpio-restart";
> + gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
> + };
> };
>
> &uart0 {
> --
> 2.7.4
>

2020-03-05 20:30:50

by Palmer Dabbelt

Subject: Re: [PATCH] riscv: dts: Add GPIO reboot method to HiFive Unleashed DTS file

On Tue, 18 Feb 2020 19:49:07 PST (-0800), [email protected] wrote:
> Add the ability to reboot the HiFive Unleashed board via GPIO.
>
> Signed-off-by: Yash Shah <[email protected]>
> ---
> arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 609198c..4a2729f 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -2,6 +2,7 @@
> /* Copyright (c) 2018-2019 SiFive, Inc */
>
> #include "fu540-c000.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> /* Clock frequency (in Hz) of the PCB crystal for rtcclk */
> #define RTCCLK_FREQ 1000000
> @@ -41,6 +42,10 @@
> clock-frequency = <RTCCLK_FREQ>;
> clock-output-names = "rtcclk";
> };
> + gpio-restart {
> + compatible = "gpio-restart";
> + gpios = <&gpio 10 GPIO_ACTIVE_LOW>;
> + };
> };
>
> &uart0 {

Thanks, this is on fixes -- I figure that given it's just a DT change there's
no reason to delay it.