2024-05-28 22:53:44

by Nathan Morrisson

[permalink] [raw]
Subject: [PATCH v2 1/4] arm64: dts: ti: k3-am64-phycore-som: Add serial_flash label

Label the spi nor as serial_flash. This allows us to disable the
flash with an overlay common to all am6xx-phycore-som boards.

Signed-off-by: Nathan Morrisson <[email protected]>
---
v2: No change

arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
index 125e507966fb..ca0bbf21f7fe 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
@@ -296,7 +296,7 @@ &ospi0 {
pinctrl-names = "default";
pinctrl-0 = <&ospi0_pins_default>;

- flash@0 {
+ serial_flash: flash@0 {
compatible = "jedec,spi-nor";
reg = <0x0>;
spi-tx-bus-width = <8>;
--
2.25.1



2024-05-31 08:43:29

by Wadim Egorov

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am64-phycore-som: Add serial_flash label



Am 29.05.24 um 00:51 schrieb Nathan Morrisson:
> Label the spi nor as serial_flash. This allows us to disable the
> flash with an overlay common to all am6xx-phycore-som boards.
>
> Signed-off-by: Nathan Morrisson <[email protected]>

For all 3 patches,

Reviewed-by: Wadim Egorov <[email protected]>

> ---
> v2: No change
>
> arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> index 125e507966fb..ca0bbf21f7fe 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi
> @@ -296,7 +296,7 @@ &ospi0 {
> pinctrl-names = "default";
> pinctrl-0 = <&ospi0_pins_default>;
>
> - flash@0 {
> + serial_flash: flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0x0>;
> spi-tx-bus-width = <8>;

2024-05-31 08:54:06

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am64-phycore-som: Add serial_flash label

On 31/05/2024 10:28, Wadim Egorov wrote:
>
>
> Am 29.05.24 um 00:51 schrieb Nathan Morrisson:
>> Label the spi nor as serial_flash. This allows us to disable the
>> flash with an overlay common to all am6xx-phycore-som boards.
>>
>> Signed-off-by: Nathan Morrisson <[email protected]>
>
> For all 3 patches,
>
> Reviewed-by: Wadim Egorov <[email protected]>

Tooling does not work like this. You need to review each or provide tag
for 4 (not three) in cover letter.

Best regards,
Krzysztof


2024-05-31 08:57:34

by Wadim Egorov

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am64-phycore-som: Add serial_flash label



Am 31.05.24 um 10:53 schrieb Krzysztof Kozlowski:
> On 31/05/2024 10:28, Wadim Egorov wrote:
>>
>>
>> Am 29.05.24 um 00:51 schrieb Nathan Morrisson:
>>> Label the spi nor as serial_flash. This allows us to disable the
>>> flash with an overlay common to all am6xx-phycore-som boards.
>>>
>>> Signed-off-by: Nathan Morrisson <[email protected]>
>>
>> For all 3 patches,
>>
>> Reviewed-by: Wadim Egorov <[email protected]>
>
> Tooling does not work like this. You need to review each or provide tag
> for 4 (not three) in cover letter.

4 patches, you are right. Missed that.

>
> Best regards,
> Krzysztof
>