2020-02-26 05:35:12

by Jitao Shi

Subject: [PATCH v9 0/5] mt8183 dpi supports dual edge and pin mode swap

Changes since v8:
- drop pclk-sample redefine in mediatek,dpi.txt
- only get the gpiomode and dpimode when dpi->pinctrl is successful.

Changes since v7:
- separate dt-bindings to independent patches.
- move dpi dual edge to one patch.

Changes since v6:
- change dual_edge to pclk-sample
- remove dpi_pin_mode_swap and

Changes since v5:
- fine tune the dt-bindings commit message.

Changes since v4:
- move pin mode control and dual edge control to deveice tree.
- update dt-bindings document for pin mode swap and dual edge control.

Changes since v3:
- add dpi pin mode control when dpi on or off.
- update dpi dual edge comment.

Changes since v2:
- update dt-bindings document for mt8183 dpi.
- separate dual edge modfication as independent patch.

Jitao Shi (5):
dt-bindings: media: add pclk-sample dual edge property
dt-bindings: display: mediatek: control dpi pins mode to avoid leakage
dt-bindings: display: mediatek: dpi sample data in dual edge support
drm/mediatek: dpi sample mode support
drm/mediatek: set dpi pin mode to gpio low to avoid leakage current

.../display/mediatek/mediatek,dpi.txt | 9 ++++
.../bindings/media/video-interfaces.txt | 4 +-
drivers/gpu/drm/mediatek/mtk_dpi.c | 49 ++++++++++++++++++-
3 files changed, 58 insertions(+), 4 deletions(-)

--
2.21.0

2020-02-26 05:36:36

by Jitao Shi

Subject: [PATCH v9 3/5] dt-bindings: display: mediatek: dpi sample data in dual edge support

Add property "pclk-sample" to config the dpi sample on falling (0),
rising (1), both falling and rising (2).

Signed-off-by: Jitao Shi <[email protected]>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
index a7b1b8bfb65e..4299aa1adf45 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
@@ -20,6 +20,7 @@ Required properties:
Optional properties:
- pinctrl-names: Contain "gpiomode" and "dpimode".
pinctrl-names see Documentation/devicetree/bindings/pinctrlpinctrl-bindings.txt
+- pclk-sample: refer Documentation/devicetree/bindings/media/video-interfaces.txt.

Example:

@@ -37,6 +38,7 @@ dpi0: dpi@1401d000 {

port {
dpi0_out: endpoint {
+ pclk-sample = 0;
remote-endpoint = <&hdmi0_in>;
};
};
--
2.21.0

2020-02-26 08:12:16

by CK Hu (胡俊光)

Subject: Re: [PATCH v9 3/5] dt-bindings: display: mediatek: dpi sample data in dual edge support

Hi, Jitao:

On Wed, 2020-02-26 at 13:32 +0800, Jitao Shi wrote:
> Add property "pclk-sample" to config the dpi sample on falling (0),
> rising (1), both falling and rising (2).
>

Reviewed-by: CK Hu <[email protected]>

> Signed-off-by: Jitao Shi <[email protected]>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> index a7b1b8bfb65e..4299aa1adf45 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> @@ -20,6 +20,7 @@ Required properties:
> Optional properties:
> - pinctrl-names: Contain "gpiomode" and "dpimode".
> pinctrl-names see Documentation/devicetree/bindings/pinctrlpinctrl-bindings.txt
> +- pclk-sample: refer Documentation/devicetree/bindings/media/video-interfaces.txt.
>
> Example:
>
> @@ -37,6 +38,7 @@ dpi0: dpi@1401d000 {
>
> port {
> dpi0_out: endpoint {
> + pclk-sample = 0;
> remote-endpoint = <&hdmi0_in>;
> };
> };

2020-02-27 17:19:31

by Rob Herring (Arm)

Subject: Re: [PATCH v9 3/5] dt-bindings: display: mediatek: dpi sample data in dual edge support

On Wed, Feb 26, 2020 at 01:32:36PM +0800, Jitao Shi wrote:
> Add property "pclk-sample" to config the dpi sample on falling (0),
> rising (1), both falling and rising (2).
>
> Signed-off-by: Jitao Shi <[email protected]>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> index a7b1b8bfb65e..4299aa1adf45 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> @@ -20,6 +20,7 @@ Required properties:
> Optional properties:
> - pinctrl-names: Contain "gpiomode" and "dpimode".
> pinctrl-names see Documentation/devicetree/bindings/pinctrlpinctrl-bindings.txt
> +- pclk-sample: refer Documentation/devicetree/bindings/media/video-interfaces.txt.
>
> Example:
>
> @@ -37,6 +38,7 @@ dpi0: dpi@1401d000 {
>
> port {
> dpi0_out: endpoint {
> + pclk-sample = 0;

Not valid dts syntax: <0>

> remote-endpoint = <&hdmi0_in>;
> };
> };
> --
> 2.21.0
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel