2020-03-06 01:27:02

by Randy Dunlap

Subject: [PATCH] drm: unbreak the DRM menu, broken by DRM_EXPORT_FOR_TESTS

From: Randy Dunlap <[email protected]>

Unbreak the DRM menu. This Kconfig symbol does not depend on DRM,
so the menu is broken at that point.

Move the symbol to a location in the Kconfig file so that it does
not break the dependency continuity.

Fixes: 6349120ddcbf ("drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Chris Wilson <[email protected]>
Cc: Daniel Vetter <[email protected]>
---
drivers/gpu/drm/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-next-20200305.orig/drivers/gpu/drm/Kconfig
+++ linux-next-20200305/drivers/gpu/drm/Kconfig
@@ -54,9 +54,6 @@ config DRM_DEBUG_MM

If in doubt, say "N".

-config DRM_EXPORT_FOR_TESTS
- bool
-
config DRM_DEBUG_SELFTEST
tristate "kselftests for DRM"
depends on DRM
@@ -470,6 +467,9 @@ config DRM_SAVAGE

endif # DRM_LEGACY

+config DRM_EXPORT_FOR_TESTS
+ bool
+
# Separate option because drm_panel_orientation_quirks.c is shared with fbdev
config DRM_PANEL_ORIENTATION_QUIRKS
tristate

2020-03-06 11:06:07

by Chris Wilson

Subject: Re: [PATCH] drm: unbreak the DRM menu, broken by DRM_EXPORT_FOR_TESTS

Quoting Randy Dunlap (2020-03-06 01:26:10)
> From: Randy Dunlap <[email protected]>
>
> Unbreak the DRM menu. This Kconfig symbol does not depend on DRM,
> so the menu is broken at that point.
>
> Move the symbol to a location in the Kconfig file so that it does
> not break the dependency continuity.

I suspect it was me, thanks for fixing it!

> Fixes: 6349120ddcbf ("drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Chris Wilson <[email protected]>
> Cc: Daniel Vetter <[email protected]>
Reviewed-by: Chris Wilson <[email protected]>
-Chris