2020-03-09 00:46:04

by Anson Huang

Subject: [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support

Add COMPILE_TEST support to i.MX SCU drivers for better compile
testing coverage.

Signed-off-by: Anson Huang <[email protected]>
---
No change.
---
drivers/firmware/imx/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig
index 1d2e5b8..116707a 100644
--- a/drivers/firmware/imx/Kconfig
+++ b/drivers/firmware/imx/Kconfig
@@ -12,7 +12,7 @@ config IMX_DSP

config IMX_SCU
bool "IMX SCU Protocol driver"
- depends on IMX_MBOX
+ depends on IMX_MBOX || COMPILE_TEST
help
The System Controller Firmware (SCFW) is a low-level system function
which runs on a dedicated Cortex-M core to provide power, clock, and
@@ -24,6 +24,6 @@ config IMX_SCU

config IMX_SCU_PD
bool "IMX SCU Power Domain driver"
- depends on IMX_SCU
+ depends on IMX_SCU || COMPILE_TEST
help
The System Controller Firmware (SCFW) based power domain driver.
--
2.7.4

2020-03-16 00:55:03

by Shawn Guo

Subject: Re: [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support

On Mon, Mar 09, 2020 at 08:38:15AM +0800, Anson Huang wrote:
> Add COMPILE_TEST support to i.MX SCU drivers for better compile
> testing coverage.
>
> Signed-off-by: Anson Huang <[email protected]>

Applied this one, thanks.

2020-03-16 03:39:27

by Shawn Guo

Subject: Re: [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support

On Mon, Mar 09, 2020 at 08:38:15AM +0800, Anson Huang wrote:
> Add COMPILE_TEST support to i.MX SCU drivers for better compile
> testing coverage.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> No change.
> ---
> drivers/firmware/imx/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig
> index 1d2e5b8..116707a 100644
> --- a/drivers/firmware/imx/Kconfig
> +++ b/drivers/firmware/imx/Kconfig
> @@ -12,7 +12,7 @@ config IMX_DSP
>
> config IMX_SCU
> bool "IMX SCU Protocol driver"
> - depends on IMX_MBOX
> + depends on IMX_MBOX || COMPILE_TEST
> help
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and
> @@ -24,6 +24,6 @@ config IMX_SCU
>
> config IMX_SCU_PD
> bool "IMX SCU Power Domain driver"
> - depends on IMX_SCU
> + depends on IMX_SCU || COMPILE_TEST

Just reminded by Peng, as we go without adding stubs for !IMX_SCU, any
driver depending on IMX_SCU shouldn't have COMPILE_TEST. I fixed it up
by dropping COMPILE_TEST from IMX_SCU_PD.

Shawn

> help
> The System Controller Firmware (SCFW) based power domain driver.
> --
> 2.7.4
>